diff options
| author | Jacob Garber <jgarber1@ualberta.ca> | 2019-07-25 19:12:31 -0600 |
|---|---|---|
| committer | Nico Huber <nico.h@gmx.de> | 2019-10-04 14:35:20 +0000 |
| commit | 4a84ec273a487c27f91bd3df70cbdf8894af70e1 (patch) | |
| tree | faee09346d0a195ac778befa68a87c5f669cfe22 /buspirate_spi.c | |
| parent | de77ad4678cb33ca0b58edf89fab8113eb304bcd (diff) | |
| download | flashrom-4a84ec273a487c27f91bd3df70cbdf8894af70e1.tar.gz flashrom-4a84ec273a487c27f91bd3df70cbdf8894af70e1.tar.bz2 flashrom-4a84ec273a487c27f91bd3df70cbdf8894af70e1.zip | |
tree: Enable -Wwrite-strings
When compiling, this warning gives string literals the type const char[]
to help catch accidental modification (which is undefined behaviour).
There currently aren't any instances of this in flashrom, so let's
enable this warning to keep it that way. This requires adding const
qualifiers to the declarations of several variables that work with
string literals.
Change-Id: I62d9bc194938a0c9a0e4cdff7ced8ea2e14cc1bc
Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/34577
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: David Hendricks <david.hendricks@gmail.com>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Diffstat (limited to 'buspirate_spi.c')
| -rw-r--r-- | buspirate_spi.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/buspirate_spi.c b/buspirate_spi.c index 08cd04cfb..826bd8412 100644 --- a/buspirate_spi.c +++ b/buspirate_spi.c @@ -113,7 +113,7 @@ static int buspirate_sendrecv(unsigned char *buf, unsigned int writecnt, return 0; } -static int buspirate_wait_for_string(unsigned char *buf, char *key) +static int buspirate_wait_for_string(unsigned char *buf, const char *key) { unsigned int keylen = strlen(key); int ret; |