diff options
| author | Nikolai Artemiev <nartemiev@google.com> | 2021-10-28 16:18:28 +1100 |
|---|---|---|
| committer | Edward O'Callaghan <quasisec@chromium.org> | 2022-04-05 02:26:09 +0000 |
| commit | 005d32b7b781c355f22d04ceb532c4fa4656801a (patch) | |
| tree | c6dbbcfc944b256fca7208bd93beb4a2838123d2 /chipdrivers.h | |
| parent | e5389d1b8fa18932a7aa3be5fee094c5023d1251 (diff) | |
| download | flashrom-005d32b7b781c355f22d04ceb532c4fa4656801a.tar.gz flashrom-005d32b7b781c355f22d04ceb532c4fa4656801a.tar.bz2 flashrom-005d32b7b781c355f22d04ceb532c4fa4656801a.zip | |
spi25_statusreg: delete spi_read_status_register()
Delete the spi_read_status_register() function because the generic
spi_read_register() function can be used instead.
This patch also converts all call sites over to spi_read_register().
A side effect is that error codes are now properly propagated and
checked.
BUG=b:195381327,b:153800563
BRANCH=none
TEST=flashrom -{r,w,E}
TEST=Tested with a W25Q128.W flash on a kasumi (AMD) dut.
Read SR1/SR2 with --wp-status and activated various WP ranges
that toggled bits in both SR1 and SR2.
Change-Id: I146b4b5439872e66c5d33e156451a729d248c7da
Signed-off-by: Nikolai Artemiev <nartemiev@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/59529
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Diffstat (limited to 'chipdrivers.h')
| -rw-r--r-- | chipdrivers.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/chipdrivers.h b/chipdrivers.h index c223534a8..0695993a8 100644 --- a/chipdrivers.h +++ b/chipdrivers.h @@ -62,8 +62,6 @@ int spi_set_extended_address(struct flashctx *, uint8_t addr_high); /* spi25_statusreg.c */ -/* FIXME: replace spi_read_status_register() calls with spi_read_register() */ -uint8_t spi_read_status_register(const struct flashctx *flash); int spi_read_register(const struct flashctx *flash, enum flash_reg reg, uint8_t *value); int spi_write_register(const struct flashctx *flash, enum flash_reg reg, uint8_t value); void spi_prettyprint_status_register_bit(uint8_t status, int bit); |