diff options
| author | Nico Huber <nico.h@gmx.de> | 2018-12-23 20:03:35 +0100 |
|---|---|---|
| committer | Nico Huber <nico.h@gmx.de> | 2019-07-31 08:26:59 +0000 |
| commit | 519be66fc59558971dd653afe69ccaf1a633b492 (patch) | |
| tree | 74f0912de156a86d56111f377db080246e5205e9 /dummyflasher.c | |
| parent | ef78de4a21323b8c459337356289218211f2c5ce (diff) | |
| download | flashrom-519be66fc59558971dd653afe69ccaf1a633b492.tar.gz flashrom-519be66fc59558971dd653afe69ccaf1a633b492.tar.bz2 flashrom-519be66fc59558971dd653afe69ccaf1a633b492.zip | |
Fix -Wsign-compare trouble
Mostly by changing to `unsigned` types where applicable, sometimes
`signed` types, and casting as a last resort.
Change-Id: I08895543ffb7a48058bcf91ef6500ca113f2d305
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/30409
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jacob Garber <jgarber1@ualberta.ca>
Diffstat (limited to 'dummyflasher.c')
| -rw-r--r-- | dummyflasher.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/dummyflasher.c b/dummyflasher.c index 8f3dfda96..0caffc9f8 100644 --- a/dummyflasher.c +++ b/dummyflasher.c @@ -58,8 +58,8 @@ static unsigned int emu_jedec_ce_60_size = 0; static unsigned int emu_jedec_ce_c7_size = 0; static unsigned char spi_blacklist[256]; static unsigned char spi_ignorelist[256]; -static int spi_blacklist_size = 0; -static int spi_ignorelist_size = 0; +static unsigned int spi_blacklist_size = 0; +static unsigned int spi_ignorelist_size = 0; static uint8_t emu_status = 0; /* A legit complete SFDP table based on the MX25L6436E (rev. 1.8) datasheet. */ @@ -151,7 +151,7 @@ int dummy_init(void) { char *bustext = NULL; char *tmp = NULL; - int i; + unsigned int i; #if EMULATE_SPI_CHIP char *status = NULL; #endif @@ -231,7 +231,7 @@ int dummy_init(void) msg_pdbg("SPI blacklist is "); for (i = 0; i < spi_blacklist_size; i++) msg_pdbg("%02x ", spi_blacklist[i]); - msg_pdbg(", size %i\n", spi_blacklist_size); + msg_pdbg(", size %u\n", spi_blacklist_size); } free(tmp); @@ -267,7 +267,7 @@ int dummy_init(void) msg_pdbg("SPI ignorelist is "); for (i = 0; i < spi_ignorelist_size; i++) msg_pdbg("%02x ", spi_ignorelist[i]); - msg_pdbg(", size %i\n", spi_ignorelist_size); + msg_pdbg(", size %u\n", spi_ignorelist_size); } free(tmp); @@ -819,7 +819,7 @@ static int dummy_spi_send_command(struct flashctx *flash, unsigned int writecnt, const unsigned char *writearr, unsigned char *readarr) { - int i; + unsigned int i; msg_pspew("%s:", __func__); |