summaryrefslogtreecommitdiffstats
path: root/flash.h
diff options
context:
space:
mode:
authorAntonio Ospite <ao2@ao2.it>2018-03-03 18:40:24 +0100
committerNico Huber <nico.h@gmx.de>2018-03-23 14:31:49 +0000
commitb6e3d257f97fd4e3998e0743968d17010047b4c1 (patch)
tree6932c164c28e36b00788b35db201dbe40660e058 /flash.h
parent22418428ed28d803bfca151623bbf017d1ba6bfc (diff)
downloadflashrom-b6e3d257f97fd4e3998e0743968d17010047b4c1.tar.gz
flashrom-b6e3d257f97fd4e3998e0743968d17010047b4c1.tar.bz2
flashrom-b6e3d257f97fd4e3998e0743968d17010047b4c1.zip
Fix compilation with older MinGW versions
The __MINGW_PRINTF_FORMAT constant has been defined back in 2012 https://sourceforge.net/p/mingw-w64/mingw-w64/ci/77bc5d6103b5fb9f59fbddab1583e69549913312/ However older toolchains are still around and some user reported the following compilation failure: flash.h:336:1: error: '__MINGW_PRINTF_FORMAT' is an unrecognized format function  type [-Werror=format=]  __attribute__((format(__MINGW_PRINTF_FORMAT, 2, 3))); Fix this by defining the constant when it isn't already; the change does not affect other compilers because it's guarded by "#ifdef __MINGW32__". Setting __MINGW_PRINTF_FORMAT to gnu_printf is exactly what newer MinGW versions do when __USE_MINGW_ANSI_STDIO is defined, which it is in flashrom Makefile. Change-Id: I48de3e4303b9a389c515a8ce230282d9210576fd Tested-by: Miklos Marton <martonmiklosqdev@gmail.com> Signed-off-by: Antonio Ospite <ao2@ao2.it> Reviewed-on: https://review.coreboot.org/25130 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Nico Huber <nico.h@gmx.de>
Diffstat (limited to 'flash.h')
-rw-r--r--flash.h3
1 files changed, 3 insertions, 0 deletions
diff --git a/flash.h b/flash.h
index a80a9c249..40a7f1a50 100644
--- a/flash.h
+++ b/flash.h
@@ -360,6 +360,9 @@ int flashrom_print_cb(enum flashrom_log_level level, const char *fmt, va_list ap
/* Let gcc and clang check for correct printf-style format strings. */
int print(enum flashrom_log_level level, const char *fmt, ...)
#ifdef __MINGW32__
+# ifndef __MINGW_PRINTF_FORMAT
+# define __MINGW_PRINTF_FORMAT gnu_printf
+# endif
__attribute__((format(__MINGW_PRINTF_FORMAT, 2, 3)));
#else
__attribute__((format(printf, 2, 3)));