diff options
| author | Edward O'Callaghan <quasisec@google.com> | 2022-11-12 12:00:24 +1100 |
|---|---|---|
| committer | Edward O'Callaghan <quasisec@chromium.org> | 2022-11-21 04:47:33 +0000 |
| commit | 7c976e34631ca4ee6345bd109a3d5ae32e9c7246 (patch) | |
| tree | a1c441e0b711ebaad52454bd30e2d2d58639e231 /flashrom.c | |
| parent | 347dba5414216cdf09ec6f0f344e4eb5f92ff4c0 (diff) | |
| download | flashrom-7c976e34631ca4ee6345bd109a3d5ae32e9c7246.tar.gz flashrom-7c976e34631ca4ee6345bd109a3d5ae32e9c7246.tar.bz2 flashrom-7c976e34631ca4ee6345bd109a3d5ae32e9c7246.zip | |
flashrom.c: Drop redundant chip read validation in verify_range()
The 'chip_safety_check()' already validates the chip structure
within 'prepare_flash_access()' before all subsequent chip operations
such as 'verify_range()' and therefore the chip structure is
guaranteed to be valid in the domain of those operations.
BUG=none
BRANCH=none
TEST=builds
Change-Id: Ifc57dd89715115e03d013691352463a8b3c0dc52
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/69471
Reviewed-by: Felix Singer <felixsinger@posteo.net>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'flashrom.c')
| -rw-r--r-- | flashrom.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/flashrom.c b/flashrom.c index 5483af374..51a6b6443 100644 --- a/flashrom.c +++ b/flashrom.c @@ -511,11 +511,6 @@ int verify_range(struct flashctx *flash, const uint8_t *cmpbuf, unsigned int sta return -1; } - if (!lookup_read_func_ptr(flash->chip)) { - msg_cerr("ERROR: flashrom has no read function for this flash chip.\n"); - return -1; - } - uint8_t *readbuf = malloc(len); if (!readbuf) { msg_gerr("Could not allocate memory!\n"); |