diff options
| author | Edward O'Callaghan <quasisec@google.com> | 2022-12-20 12:33:13 +1100 |
|---|---|---|
| committer | Thomas Heijligen <src@posteo.de> | 2023-03-03 17:35:50 +0000 |
| commit | e1f30bbce7a603d518ecec9d7e6885719f396719 (patch) | |
| tree | 8eb630273f026b859d29a9b7854d447cb43c122f /flashrom.c | |
| parent | c66d2bd1ca384dd673b24420e11865fde86060fc (diff) | |
| download | flashrom-e1f30bbce7a603d518ecec9d7e6885719f396719.tar.gz flashrom-e1f30bbce7a603d518ecec9d7e6885719f396719.tar.bz2 flashrom-e1f30bbce7a603d518ecec9d7e6885719f396719.zip | |
tree/: Drop default_spi_probe_opcode for NULL case
A NULL func pointer is necessary and sufficient for the
condition `NULL func pointer => true' as to not need this
boilerplate as it implies default behaviour of a supported
opcode within the `check_block_eraser()` match supported loop.
Ran;
```
$ find . -name '*.[c,h]' -exec sed -i '/.probe_opcode = default_spi_probe_opcode,/d' '{}' \;
```
Change-Id: Id502c5d2596ad1db52faf05723083620e4c52c12
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/70264
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Thomas Heijligen <src@posteo.de>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Diffstat (limited to 'flashrom.c')
| -rw-r--r-- | flashrom.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/flashrom.c b/flashrom.c index 62e575761..3cf67f1d0 100644 --- a/flashrom.c +++ b/flashrom.c @@ -470,7 +470,7 @@ int check_block_eraser(const struct flashctx *flash, int k, int log) if (flash->mst->buses_supported & BUS_SPI) { const uint8_t *opcode = spi_get_opcode_from_erasefn(eraser.block_erase); for (int i = 0; opcode[i]; i++) { - if (!flash->mst->spi.probe_opcode(flash, opcode[i])) { + if (!spi_probe_opcode(flash, opcode[i])) { if (log) msg_cdbg("block erase function and layout found " "but SPI master doesn't support the function. "); |