summaryrefslogtreecommitdiffstats
path: root/helpers.c
diff options
context:
space:
mode:
authorDaniel Campello <campello@chromium.org>2022-03-16 07:05:48 -0600
committerAnastasia Klimchuk <aklm@chromium.org>2022-03-21 02:11:02 +0000
commite1dd0068c2f1d77d10d2da843f6b32b8f30fd788 (patch)
tree8800736685917237097336dc33327c8d13e872e3 /helpers.c
parentf31650b23b4b80f86b7fe0ec879984439a32838c (diff)
downloadflashrom-e1dd0068c2f1d77d10d2da843f6b32b8f30fd788.tar.gz
flashrom-e1dd0068c2f1d77d10d2da843f6b32b8f30fd788.tar.bz2
flashrom-e1dd0068c2f1d77d10d2da843f6b32b8f30fd788.zip
helpers.c: use unsigned int for bit shifts (ASAN)
This change addresses the following ASAN error detected in the chromium tree: * ASAN error detected: * ../flashrom-9999/helpers.c:28:13: runtime error: left shift of 1 by 31 places cannot be represented in type 'int' * #0 0x5589a94bb284 in address_to_bits /build/amd64-generic/tmp/portage/sys-apps/flashrom-9999/work/flashrom-9999-build/../flashrom-9999/helpers.c:28:13 * * SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../flashrom-9999/helpers.c:28:13 in BUG=b:224828279 TEST=./test_build.sh; FEATURES=test emerge-amd64-generic flashrom BRANCH=none Signed-off-by: Daniel Campello <campello@chromium.org> Change-Id: Ib595f13c29dd5c0775e074801756e4f920b4daaf Reviewed-on: https://review.coreboot.org/c/flashrom/+/62862 Reviewed-by: Anastasia Klimchuk <aklm@chromium.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Edward O'Callaghan <quasisec@chromium.org> Reviewed-by: Paul Menzel <paulepanter@mailbox.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'helpers.c')
-rw-r--r--helpers.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/helpers.c b/helpers.c
index 289848d7d..5b47b68c6 100644
--- a/helpers.c
+++ b/helpers.c
@@ -25,7 +25,7 @@
uint32_t address_to_bits(uint32_t addr)
{
unsigned int lzb = 0;
- while (((1 << (31 - lzb)) & ~addr) != 0)
+ while (((1u << (31 - lzb)) & ~addr) != 0)
lzb++;
return 32 - lzb;
}