summaryrefslogtreecommitdiffstats
path: root/it8212.c
diff options
context:
space:
mode:
authorEdward O'Callaghan <quasisec@google.com>2023-01-09 10:43:47 +1100
committerEdward O'Callaghan <quasisec@chromium.org>2023-01-11 22:51:35 +0000
commita031c81f51eae94877a5076cd1a585d3cbf1bb5c (patch)
treea73023d1aa7911313c4099c994f92c50a76e1ca1 /it8212.c
parent4ae3ac3062230f3c7f3f16a5cdd4682b98bd7d2f (diff)
downloadflashrom-a031c81f51eae94877a5076cd1a585d3cbf1bb5c.tar.gz
flashrom-a031c81f51eae94877a5076cd1a585d3cbf1bb5c.tar.bz2
flashrom-a031c81f51eae94877a5076cd1a585d3cbf1bb5c.zip
parallel: Drop explicit fallback_chip_X boilerplate
A NULL func pointer is necessary and sufficient for the condition `NULL func pointer => fallback_chip_X' as to not need this explicit specification. Therefore drop the explicit need to specify these fallback callback function pointer in the par_master struct. This is a reasonable default for every driver in the tree. Furthermore, move the 'fallback_chip_X()' func from the generic programmer.c register logic into its relevant home of parallel.c and make static local to clean up link-time symbol space. This simplifies the code and driver development. Change-Id: If25c0048a07057aa72be6ffa8d8ad7f0a568dcf7 Signed-off-by: Edward O'Callaghan <quasisec@google.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/71745 Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'it8212.c')
-rw-r--r--it8212.c6
1 files changed, 0 insertions, 6 deletions
diff --git a/it8212.c b/it8212.c
index 8fe2b5985..3c1161d60 100644
--- a/it8212.c
+++ b/it8212.c
@@ -64,13 +64,7 @@ static int it8212_shutdown(void *par_data)
static const struct par_master par_master_it8212 = {
.chip_readb = it8212_chip_readb,
- .chip_readw = fallback_chip_readw,
- .chip_readl = fallback_chip_readl,
- .chip_readn = fallback_chip_readn,
.chip_writeb = it8212_chip_writeb,
- .chip_writew = fallback_chip_writew,
- .chip_writel = fallback_chip_writel,
- .chip_writen = fallback_chip_writen,
.shutdown = it8212_shutdown,
};