summaryrefslogtreecommitdiffstats
path: root/it8212.c
diff options
context:
space:
mode:
authorEdward O'Callaghan <quasisec@google.com>2021-05-24 20:33:45 +1000
committerEdward O'Callaghan <quasisec@chromium.org>2021-05-27 02:36:32 +0000
commitad8eb60e5d559e113a73e13213846938fded03de (patch)
tree62ab8787767ec99a6948ad53e38aef771bab5c1c /it8212.c
parent4f537721036c73381c073c7c9a1569275fd4333a (diff)
downloadflashrom-ad8eb60e5d559e113a73e13213846938fded03de.tar.gz
flashrom-ad8eb60e5d559e113a73e13213846938fded03de.tar.bz2
flashrom-ad8eb60e5d559e113a73e13213846938fded03de.zip
par_masters: Reshuffle to remove forward declarations
Dispense with all these forward declarations by way of ordering. Just deal with all the par_masters in one go to be over and done with. BUG=none BRANCH=none TEST=builds Change-Id: I88e89992380195fee7c9de7ec57502ab980ec5df Signed-off-by: Edward O'Callaghan <quasisec@google.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/54873 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm@chromium.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'it8212.c')
-rw-r--r--it8212.c22
1 files changed, 10 insertions, 12 deletions
diff --git a/it8212.c b/it8212.c
index 2f2d43ea4..7c66a59ef 100644
--- a/it8212.c
+++ b/it8212.c
@@ -32,8 +32,16 @@ const struct dev_entry devs_it8212[] = {
#define IT8212_MEMMAP_SIZE (128 * 1024)
#define IT8212_MEMMAP_MASK (IT8212_MEMMAP_SIZE - 1)
-static void it8212_chip_writeb(const struct flashctx *flash, uint8_t val, chipaddr addr);
-static uint8_t it8212_chip_readb(const struct flashctx *flash, const chipaddr addr);
+static void it8212_chip_writeb(const struct flashctx *flash, uint8_t val, chipaddr addr)
+{
+ pci_mmio_writeb(val, it8212_bar + (addr & IT8212_MEMMAP_MASK));
+}
+
+static uint8_t it8212_chip_readb(const struct flashctx *flash, const chipaddr addr)
+{
+ return pci_mmio_readb(it8212_bar + (addr & IT8212_MEMMAP_MASK));
+}
+
static const struct par_master par_master_it8212 = {
.chip_readb = it8212_chip_readb,
.chip_readw = fallback_chip_readw,
@@ -70,13 +78,3 @@ int it8212_init(void)
register_par_master(&par_master_it8212, BUS_PARALLEL, NULL);
return 0;
}
-
-static void it8212_chip_writeb(const struct flashctx *flash, uint8_t val, chipaddr addr)
-{
- pci_mmio_writeb(val, it8212_bar + (addr & IT8212_MEMMAP_MASK));
-}
-
-static uint8_t it8212_chip_readb(const struct flashctx *flash, const chipaddr addr)
-{
- return pci_mmio_readb(it8212_bar + (addr & IT8212_MEMMAP_MASK));
-}