diff options
author | Nico Huber <nico.h@gmx.de> | 2021-05-14 01:13:33 +0200 |
---|---|---|
committer | Nico Huber <nico.h@gmx.de> | 2021-06-26 16:00:19 +0000 |
commit | d0fa8c0408cbc785de2aadbf57b30d941087831a (patch) | |
tree | ecc792b8e0aa413cffe05e8d1436eff3f014d2cd /layout.h | |
parent | 7dd1624a7dcbe8e7600de78d1d0c09274bbd30ae (diff) | |
download | flashrom-d0fa8c0408cbc785de2aadbf57b30d941087831a.tar.gz flashrom-d0fa8c0408cbc785de2aadbf57b30d941087831a.tar.bz2 flashrom-d0fa8c0408cbc785de2aadbf57b30d941087831a.zip |
layout: Tidy up forward declarations
* Parameter names like `flashctx` for a `struct flashrom_flashctx`
don't add any value.
* `const` qualification of parameters is meaningless in forward
declarations. Arguments are always passed by copy and an API
user does not need to know what callees do with their copy.
Change-Id: Iadcc1670ff86578a400dec9e804d6dda93e0fcf0
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/54288
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'layout.h')
-rw-r--r-- | layout.h | 14 |
1 files changed, 7 insertions, 7 deletions
@@ -51,21 +51,21 @@ struct layout_include_args; struct flashrom_flashctx; const struct flashrom_layout *get_default_layout(const struct flashrom_flashctx *); -const struct flashrom_layout *get_layout(const struct flashrom_flashctx *const flashctx); +const struct flashrom_layout *get_layout(const struct flashrom_flashctx *); int layout_from_file(struct flashrom_layout **, const char *name); -int register_include_arg(struct layout_include_args **args, const char *arg); -int process_include_args(struct flashrom_layout *l, const struct layout_include_args *const args); -void cleanup_include_args(struct layout_include_args **args); +int register_include_arg(struct layout_include_args **, const char *arg); +int process_include_args(struct flashrom_layout *, const struct layout_include_args *); +void cleanup_include_args(struct layout_include_args **); -int get_region_range(struct flashrom_layout *const l, const char *name, +int get_region_range(struct flashrom_layout *, const char *name, unsigned int *start, unsigned int *len); const struct romentry *layout_next_included_region(const struct flashrom_layout *, chipoff_t); const struct romentry *layout_next_included(const struct flashrom_layout *, const struct romentry *); const struct romentry *layout_next(const struct flashrom_layout *, const struct romentry *); -int included_regions_overlap(const struct flashrom_layout *const flashrom_layout); -void prepare_layout_for_extraction(struct flashrom_flashctx *flash); +int included_regions_overlap(const struct flashrom_layout *); +void prepare_layout_for_extraction(struct flashrom_flashctx *); int layout_sanity_checks(const struct flashrom_flashctx *); #endif /* !__LAYOUT_H__ */ |