diff options
| author | aarya <aarya.chaumal@gmail.com> | 2022-03-10 08:47:48 +0530 |
|---|---|---|
| committer | Anastasia Klimchuk <aklm@chromium.org> | 2022-03-30 01:28:05 +0000 |
| commit | 1b66464269ed829ba08b2736500712e50753cfab (patch) | |
| tree | fa0fb1405ee88e34dacfd98be1897ecafad8a309 /libflashrom.c | |
| parent | 6b85eb87c6db2eceb9fedb35c6491edcc020889f (diff) | |
| download | flashrom-1b66464269ed829ba08b2736500712e50753cfab.tar.gz flashrom-1b66464269ed829ba08b2736500712e50753cfab.tar.bz2 flashrom-1b66464269ed829ba08b2736500712e50753cfab.zip | |
libflashrom.c: Fix unintialized value passed to function
In function flash_layout_read_from_ifd variable chip_layout remains
uninitialized if prepare_flash_access returns false. This uninitialized
variable (which contains a garbage value) is passed to
flashrom_layout_release. Thus initialize it with NULL. For completeness,
also initialize dump_layout with NULL.
Change-Id: Iacbd7bf9cdf897cc2a732c1dc6568845a4ab804d
Signed-off-by: Aarya Chaumal <aarya.chaumal@gmail.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/62725
Reviewed-by: Felix Singer <felixsinger@posteo.net>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'libflashrom.c')
| -rw-r--r-- | libflashrom.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libflashrom.c b/libflashrom.c index f2288fef3..39b0c67b6 100644 --- a/libflashrom.c +++ b/libflashrom.c @@ -442,7 +442,7 @@ int flashrom_layout_read_from_ifd(struct flashrom_layout **const layout, struct #ifndef __FLASHROM_LITTLE_ENDIAN__ return 6; #else - struct flashrom_layout *dump_layout, *chip_layout; + struct flashrom_layout *dump_layout = NULL, *chip_layout = NULL; int ret = 1; void *const desc = malloc(0x1000); |