diff options
| author | Nico Huber <nico.h@gmx.de> | 2021-05-11 17:53:34 +0200 |
|---|---|---|
| committer | Nico Huber <nico.h@gmx.de> | 2021-05-13 14:37:43 +0000 |
| commit | 90739d147f1d9b90789873fdbe74da6c616cad6b (patch) | |
| tree | 019d727f7b3289a0d71c831374e2f33c3ae1b66a /linux_spi.c | |
| parent | 7e4968525d37d87e8b6f8b848e4f2f9696926237 (diff) | |
| download | flashrom-90739d147f1d9b90789873fdbe74da6c616cad6b.tar.gz flashrom-90739d147f1d9b90789873fdbe74da6c616cad6b.tar.bz2 flashrom-90739d147f1d9b90789873fdbe74da6c616cad6b.zip | |
programmer: Make use of new register_spi_master() API
Pass pointers to dynamically allocated data to register_spi_master().
This way we can avoid some mutable globals.
Change-Id: Id7821f1db3284b7b5b3d0abfd878b979c53870a1
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/54067
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'linux_spi.c')
| -rw-r--r-- | linux_spi.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/linux_spi.c b/linux_spi.c index 82741bf60..7d866f477 100644 --- a/linux_spi.c +++ b/linux_spi.c @@ -113,7 +113,7 @@ static int linux_spi_send_command(const struct flashctx *flash, unsigned int wri return 0; } -static struct spi_master spi_master_linux = { +static const struct spi_master spi_master_linux = { .features = SPI_MASTER_4BA, .max_data_read = MAX_DATA_UNSPECIFIED, /* TODO? */ .max_data_write = MAX_DATA_UNSPECIFIED, /* TODO? */ @@ -238,13 +238,12 @@ int linux_spi_init(void) } spi_data->fd = fd; spi_data->max_kernel_buf_size = max_kernel_buf_size; - spi_master_linux.data = spi_data; if (register_shutdown(linux_spi_shutdown, spi_data)) { free(spi_data); goto init_err; } - register_spi_master(&spi_master_linux, NULL); + register_spi_master(&spi_master_linux, spi_data); return 0; init_err: |