summaryrefslogtreecommitdiffstats
path: root/ni845x_spi.c
diff options
context:
space:
mode:
authorEdward O'Callaghan <quasisec@google.com>2022-09-07 22:21:39 +1000
committerAngel Pons <th3fanbus@gmail.com>2022-10-08 18:36:21 +0000
commit67d50156170b17e5bca460ab6e5648e2b11f061c (patch)
treef46620ea3f354e0ea623c2bcbb7d48fc05e78713 /ni845x_spi.c
parent7e8d17a8bd6e8239375666920b1824c4d24d4a01 (diff)
downloadflashrom-67d50156170b17e5bca460ab6e5648e2b11f061c.tar.gz
flashrom-67d50156170b17e5bca460ab6e5648e2b11f061c.tar.bz2
flashrom-67d50156170b17e5bca460ab6e5648e2b11f061c.zip
drivers/: Make 'fallback_{un}map' the default unless defined
Drop the explicit need to specify the default 'fallback_{un}map' callback function pointer from the 'programmer_entry' struct. This is a reasonable default for every other driver in the tree with only a select few exceptions [atavia, serprog, dummyflasher and internal]. Thus this simplifies driver development and paves way to remove the 'programmer' global handle. Change-Id: I5ea7bd68f7ae2cd4af9902ef07255ab6ce0bfdb3 Signed-off-by: Edward O'Callaghan <quasisec@google.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/67404 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Felix Singer <felixsinger@posteo.net> Reviewed-by: Anastasia Klimchuk <aklm@chromium.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'ni845x_spi.c')
-rw-r--r--ni845x_spi.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/ni845x_spi.c b/ni845x_spi.c
index b5cfc06b6..2750334b9 100644
--- a/ni845x_spi.c
+++ b/ni845x_spi.c
@@ -635,6 +635,4 @@ const struct programmer_entry programmer_ni845x_spi = {
.type = OTHER, // choose other because NI-845x uses own USB implementation
.devs.note = "National Instruments USB-845x\n",
.init = ni845x_spi_init,
- .map_flash_region = fallback_map,
- .unmap_flash_region = fallback_unmap,
};