diff options
| author | Edward O'Callaghan <quasisec@google.com> | 2022-09-09 23:01:05 +1000 |
|---|---|---|
| committer | Felix Singer <felixsinger@posteo.net> | 2022-12-21 04:44:47 +0000 |
| commit | 972c1550b4d67abdfe187100905f95030e18a796 (patch) | |
| tree | b1ac9658d47757a48275e6251f48008012c77873 /ni845x_spi.c | |
| parent | 8b0250b32b89a54df16989369c0cb8330d86cb77 (diff) | |
| download | flashrom-972c1550b4d67abdfe187100905f95030e18a796.tar.gz flashrom-972c1550b4d67abdfe187100905f95030e18a796.tar.bz2 flashrom-972c1550b4d67abdfe187100905f95030e18a796.zip | |
spi: Make 'default_spi_write_aai' the default unless defined
A NULL func pointer is necessary and sufficient for the
condition `NULL func pointer => default_spi_write_aai' as to not
need this explicit specification of 'default'.
Therefore Drop the explicit need to specify the 'default_spi_write_aai'
callback function pointer in the spi_master struct. This is a reasonable default for every other driver in the tree with only a few exceptions.
This simplifies the code and driver development.
Change-Id: I7f14aaea0edcf0c08cea0e9cd27d58152707fb2a
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/67479
Reviewed-by: Peter Marheine <pmarheine@chromium.org>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Singer <felixsinger@posteo.net>
Diffstat (limited to 'ni845x_spi.c')
| -rw-r--r-- | ni845x_spi.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/ni845x_spi.c b/ni845x_spi.c index 2750334b9..fd5057dd1 100644 --- a/ni845x_spi.c +++ b/ni845x_spi.c @@ -535,7 +535,6 @@ static const struct spi_master spi_programmer_ni845x = { .multicommand = default_spi_send_multicommand, .read = default_spi_read, .write_256 = default_spi_write_256, - .write_aai = default_spi_write_aai, .shutdown = ni845x_spi_shutdown, .probe_opcode = default_spi_probe_opcode, }; |