diff options
| author | Alexander Goncharov <chat@joursoir.net> | 2023-02-14 19:31:44 +0400 |
|---|---|---|
| committer | Anastasia Klimchuk <aklm@chromium.org> | 2023-04-24 13:30:12 +0000 |
| commit | 5affc221f3074be4e7239ba2a0683cae06b525fd (patch) | |
| tree | 49b9d01b929279a5803507d0a83e157c667c9be0 /print_wiki.c | |
| parent | 590a621e164a09b9a435e12ef14800f55cf4805e (diff) | |
| download | flashrom-5affc221f3074be4e7239ba2a0683cae06b525fd.tar.gz flashrom-5affc221f3074be4e7239ba2a0683cae06b525fd.tar.bz2 flashrom-5affc221f3074be4e7239ba2a0683cae06b525fd.zip | |
flashrom: rewrite flashbuses_to_text()
The previous implementation had no error handling, as a result the
flashrom could crash if the computer ran out of memory. The new
version returns NULL in such cases.
Also, rewrite lots of `if` conditions to one cycle, store a name of
buses and `enum chipbustype` in an array by using a custom struct.
The caller always expected a non-null value, so change its behavior to
handle a possible null value or use the `?` symbol. As far as `free()`
can handle null pointers, do nothing with such callers.
TEST=ninja test
Change-Id: I59b9044c99b4ba6c00d8c97f1e91af09d70dce2c
Signed-off-by: Alexander Goncharov <chat@joursoir.net>
Ticket: https://ticket.coreboot.org/issues/408
Reviewed-on: https://review.coreboot.org/c/flashrom/+/73039
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Diffstat (limited to 'print_wiki.c')
| -rw-r--r-- | print_wiki.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/print_wiki.c b/print_wiki.c index 2c8c10934..a0cade9c1 100644 --- a/print_wiki.c +++ b/print_wiki.c @@ -325,7 +325,7 @@ static void print_supported_chips_wiki(int cols) "|| %s || {{%s}} || {{%s}} || {{%s}} || {{%s}}" "|| %s || %s\n", (c == 1) ? "eeeeee" : "dddddd", f->vendor, f->name, - f->total_size, s, + f->total_size, s ? s : "?", test_state_to_template(f->tested.probe), test_state_to_template(f->tested.read), test_state_to_template(f->tested.erase), |