diff options
| author | Edward O'Callaghan <quasisec@google.com> | 2021-11-13 13:14:06 +1100 |
|---|---|---|
| committer | Edward O'Callaghan <quasisec@chromium.org> | 2022-02-24 23:30:51 +0000 |
| commit | 634707a42d0a4670e5177638986232c4e992d403 (patch) | |
| tree | c8c0fdb6c2dc7a2a2505259b06831ec2f8432ee1 /programmer.h | |
| parent | 2740a52dbd5bf4f32daee76c0c36649b8b547725 (diff) | |
| download | flashrom-634707a42d0a4670e5177638986232c4e992d403.tar.gz flashrom-634707a42d0a4670e5177638986232c4e992d403.tar.bz2 flashrom-634707a42d0a4670e5177638986232c4e992d403.zip | |
pcidev: Avoid internal programmer relying on pacc global
Make progress towards the goal of removing pacc from global
state as noted in the FIXME of programmer.h
BUG=b:220950271
TEST=```sudo ./flashrom -p internal --flash-size
<snip>
Found Programmer flash chip "Opaque flash chip" (16384 kB, Programmer-specific) mapped at physical address 0x0000000000000000.
16777216
```
Change-Id: Id83bfd41f785f907e52a65a6689e8c7016fc1b77
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/59275
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Diffstat (limited to 'programmer.h')
| -rw-r--r-- | programmer.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/programmer.h b/programmer.h index 08e5e9cda..4024966e6 100644 --- a/programmer.h +++ b/programmer.h @@ -117,6 +117,7 @@ struct bitbang_spi_master { #if NEED_PCI == 1 struct pci_dev; +struct pci_filter; /* pcidev.c */ // FIXME: This needs to be local, not global(?) @@ -124,6 +125,7 @@ extern struct pci_access *pacc; int pci_init_common(void); uintptr_t pcidev_readbar(struct pci_dev *dev, int bar); struct pci_dev *pcidev_init(const struct dev_entry *devs, int bar); +struct pci_dev *pcidev_scandev(struct pci_filter *filter, struct pci_dev *start); /* rpci_write_* are reversible writes. The original PCI config space register * contents will be restored on shutdown. * To clone the pci_dev instances internally, the `pacc` global |