diff options
| author | Edward O'Callaghan <quasisec@google.com> | 2021-01-06 14:10:52 +1100 |
|---|---|---|
| committer | Edward O'Callaghan <quasisec@chromium.org> | 2021-01-17 07:00:05 +0000 |
| commit | ec942500661f01fa9ac95797e1878a749a94a586 (patch) | |
| tree | 0e116aff42b5958133ae8f8c1297524bb6d91a35 /programmer.h | |
| parent | 4f112f699485006f22c988a37961544141905f27 (diff) | |
| download | flashrom-ec942500661f01fa9ac95797e1878a749a94a586.tar.gz flashrom-ec942500661f01fa9ac95797e1878a749a94a586.tar.bz2 flashrom-ec942500661f01fa9ac95797e1878a749a94a586.zip | |
tree/: Drop const from opaque data ptr in master definitions [alt]
The opaque data pointer need not necessarily have constant
data for the life-time of the specific master. This is because
the data field purpose is for the master to use as it sees fit
for managing its own internal state and therefore we should not
constrain this as being RO data at init time.
BUG=none
BRANCH=none
TEST=builds
Change-Id: I686c3c79547e35d48f3fd0b524fc98c176dcea6e
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/49131
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Sam McNally <sammc@google.com>
Diffstat (limited to 'programmer.h')
| -rw-r--r-- | programmer.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/programmer.h b/programmer.h index d66d239bb..1c9ef38b0 100644 --- a/programmer.h +++ b/programmer.h @@ -634,7 +634,7 @@ struct spi_master { int (*read)(struct flashctx *flash, uint8_t *buf, unsigned int start, unsigned int len); int (*write_256)(struct flashctx *flash, const uint8_t *buf, unsigned int start, unsigned int len); int (*write_aai)(struct flashctx *flash, const uint8_t *buf, unsigned int start, unsigned int len); - const void *data; + void *data; }; int default_spi_send_command(const struct flashctx *flash, unsigned int writecnt, unsigned int readcnt, @@ -722,7 +722,7 @@ struct opaque_master { int (*read) (struct flashctx *flash, uint8_t *buf, unsigned int start, unsigned int len); int (*write) (struct flashctx *flash, const uint8_t *buf, unsigned int start, unsigned int len); int (*erase) (struct flashctx *flash, unsigned int blockaddr, unsigned int blocklen); - const void *data; + void *data; }; int register_opaque_master(const struct opaque_master *mst); @@ -745,7 +745,7 @@ struct par_master { uint16_t (*chip_readw) (const struct flashctx *flash, const chipaddr addr); uint32_t (*chip_readl) (const struct flashctx *flash, const chipaddr addr); void (*chip_readn) (const struct flashctx *flash, uint8_t *buf, const chipaddr addr, size_t len); - const void *data; + void *data; }; int register_par_master(const struct par_master *mst, const enum chipbustype buses); struct registered_master { |