summaryrefslogtreecommitdiffstats
path: root/raiden_debug_spi.c
diff options
context:
space:
mode:
authorAngel Pons <th3fanbus@gmail.com>2021-06-07 12:33:53 +0200
committerNico Huber <nico.h@gmx.de>2021-06-09 16:03:30 +0000
commit3bd47524c044168b01e54e772d23c7fa723dc0d5 (patch)
treece8c816c3bb0477afb92ed5a7fc222c68a87057c /raiden_debug_spi.c
parent14c916d3801f0f25913e66a157fc834d76cdffba (diff)
downloadflashrom-3bd47524c044168b01e54e772d23c7fa723dc0d5.tar.gz
flashrom-3bd47524c044168b01e54e772d23c7fa723dc0d5.tar.bz2
flashrom-3bd47524c044168b01e54e772d23c7fa723dc0d5.zip
treewide: Drop most cases of `sizeof(struct ...)`
Spelling out the struct type name hurts readability and introduces opportunities for bugs to happen when the pointer variable type is changed but the corresponding sizeof is (are) not. TEST=`make CONFIG_EVERYTHING=yes CONFIG_JLINK_SPI=no VERSION=none -j` with and without this patch; the flashrom executable does not change. Change-Id: Icc0b60ca6ef9f5ece6ed2a0e03600bb6ccd7dcc6 Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/55266 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Nico Huber <nico.h@gmx.de> Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Diffstat (limited to 'raiden_debug_spi.c')
-rw-r--r--raiden_debug_spi.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/raiden_debug_spi.c b/raiden_debug_spi.c
index f67bbe5ec..950b8afb1 100644
--- a/raiden_debug_spi.c
+++ b/raiden_debug_spi.c
@@ -1579,19 +1579,19 @@ loop_end:
(request_enable == RAIDEN_DEBUG_SPI_REQ_ENABLE_EC))
usleep(50 * 1000);
- struct spi_master *spi_config = calloc(1, sizeof(struct spi_master));
+ struct spi_master *spi_config = calloc(1, sizeof(*spi_config));
if (!spi_config) {
msg_perr("Unable to allocate space for SPI master.\n");
return SPI_GENERIC_ERROR;
}
- struct raiden_debug_spi_data *data = calloc(1, sizeof(struct raiden_debug_spi_data));
+ struct raiden_debug_spi_data *data = calloc(1, sizeof(*data));
if (!data) {
free(spi_config);
msg_perr("Unable to allocate space for extra SPI master data.\n");
return SPI_GENERIC_ERROR;
}
- memcpy(spi_config, &spi_master_raiden_debug, sizeof(struct spi_master));
+ memcpy(spi_config, &spi_master_raiden_debug, sizeof(*spi_config));
data->dev = device;
data->in_ep = in_endpoint;