diff options
| author | Felix Singer <felixsinger@posteo.net> | 2022-07-18 02:36:18 +0200 |
|---|---|---|
| committer | Anastasia Klimchuk <aklm@chromium.org> | 2022-07-22 01:26:25 +0000 |
| commit | e6e4ca5fe48989539a26e30417688757cfd6bf75 (patch) | |
| tree | 1bea094031740fdacfe20ba0dd800f41c36ffde4 /realtek_mst_i2c_spi.c | |
| parent | a2fc6185e68c1b5639abe2bfbfc915731cb2c5a9 (diff) | |
| download | flashrom-e6e4ca5fe48989539a26e30417688757cfd6bf75.tar.gz flashrom-e6e4ca5fe48989539a26e30417688757cfd6bf75.tar.bz2 flashrom-e6e4ca5fe48989539a26e30417688757cfd6bf75.zip | |
realtek_mst_i2c_spi: Use underscores for parameters instead hyphens
realtek_mst_i2c_spi is the only programmer which uses hyphens instead of
underscores in its parameter names. Thus, for consistency, rename the
parameters so that they use underscores.
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Change-Id: I5ff6d8d432d875670fcaa2088e9cf9d9f1b83dc2
Reviewed-on: https://review.coreboot.org/c/flashrom/+/65935
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-by: Peter Marheine <pmarheine@chromium.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Thomas Heijligen <src@posteo.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Diffstat (limited to 'realtek_mst_i2c_spi.c')
| -rw-r--r-- | realtek_mst_i2c_spi.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/realtek_mst_i2c_spi.c b/realtek_mst_i2c_spi.c index f817b9cd9..ce1637a10 100644 --- a/realtek_mst_i2c_spi.c +++ b/realtek_mst_i2c_spi.c @@ -449,7 +449,7 @@ static int get_params(int *reset, int *enter_isp, int *allow_brick) char *reset_str = NULL, *isp_str = NULL, *brick_str = NULL; int ret = 0; - brick_str = extract_programmer_param_str("allow-brick"); + brick_str = extract_programmer_param_str("allow_brick"); if (brick_str) { if (!strcmp(brick_str, "yes")) { *allow_brick = 1; @@ -462,14 +462,14 @@ static int get_params(int *reset, int *enter_isp, int *allow_brick) } free(brick_str); - reset_str = extract_programmer_param_str("reset-mcu"); + reset_str = extract_programmer_param_str("reset_mcu"); if (reset_str) { if (reset_str[0] == '1') { *reset = 1; } else if (reset_str[0] == '0') { *reset = 0; } else { - msg_perr("%s: Incorrect param format, reset-mcu=1 or 0.\n", __func__); + msg_perr("%s: Incorrect param format, reset_mcu=1 or 0.\n", __func__); ret = SPI_GENERIC_ERROR; } } else { @@ -477,14 +477,14 @@ static int get_params(int *reset, int *enter_isp, int *allow_brick) } free(reset_str); - isp_str = extract_programmer_param_str("enter-isp"); + isp_str = extract_programmer_param_str("enter_isp"); if (isp_str) { if (isp_str[0] == '1') { *enter_isp = 1; } else if (isp_str[0] == '0') { *enter_isp = 0; } else { - msg_perr("%s: Incorrect param format, enter-isp=1 or 0.\n", __func__); + msg_perr("%s: Incorrect param format, enter_isp=1 or 0.\n", __func__); ret = SPI_GENERIC_ERROR; } } else { @@ -508,9 +508,9 @@ static int realtek_mst_i2c_spi_init(void) * then this can be removed. */ if (!allow_brick) { - msg_perr("%s: For i2c drivers you must explicitly 'allow-brick=yes'. ", __func__); + msg_perr("%s: For i2c drivers you must explicitly 'allow_brick=yes'. ", __func__); msg_perr("There is currently no way to determine if the programmer works on a board " - "as i2c device address space can be overloaded. Set 'allow-brick=yes' if " + "as i2c device address space can be overloaded. Set 'allow_brick=yes' if " "you are sure you know what you are doing.\n"); return SPI_GENERIC_ERROR; } |