diff options
| author | aarya <aarya.chaumal@gmail.com> | 2022-03-10 09:16:44 +0530 |
|---|---|---|
| committer | Anastasia Klimchuk <aklm@chromium.org> | 2022-05-12 00:17:13 +0000 |
| commit | c829a48e198d723f0e6ae1ff6d6f820eb085711d (patch) | |
| tree | e66b9f486312da2863e75d90c297a66247bc95d7 /serprog.c | |
| parent | 7228ce007cc42030393b3a33f28b6115e41591b1 (diff) | |
| download | flashrom-c829a48e198d723f0e6ae1ff6d6f820eb085711d.tar.gz flashrom-c829a48e198d723f0e6ae1ff6d6f820eb085711d.tar.bz2 flashrom-c829a48e198d723f0e6ae1ff6d6f820eb085711d.zip | |
serprog.c: Avoid calling memcpy with NULL pointer arguments
In function sp_stream_buffer_op, the variable parms might be NULL when
passed to memcpy. Although, since parmlen is also 0 at that time I
don't think it would make much difference. Still, add a NULL check
before calling memcpy to be safe.
Change-Id: I850123237e328f9548ba7f77a01888be2cbc9e7b
Signed-off-by: Aarya Chaumal <aarya.chaumal@gmail.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/62726
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-by: Thomas Heijligen <src@posteo.de>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Diffstat (limited to 'serprog.c')
| -rw-r--r-- | serprog.c | 3 |
1 files changed, 2 insertions, 1 deletions
@@ -291,7 +291,8 @@ static int sp_stream_buffer_op(uint8_t cmd, uint32_t parmlen, uint8_t *parms) return 1; } sp[0] = cmd; - memcpy(&(sp[1]), parms, parmlen); + if (parms) + memcpy(&(sp[1]), parms, parmlen); if (sp_streamed_transmit_bytes >= (1 + parmlen + sp_device_serbuf_size)) { if (sp_flush_stream() != 0) { |