summaryrefslogtreecommitdiffstats
path: root/util/flashrom_tester/flashrom/src/lib.rs
diff options
context:
space:
mode:
authorNikolai Artemiev <nartemiev@google.com>2022-11-23 10:17:56 +1100
committerEdward O'Callaghan <quasisec@chromium.org>2022-12-21 03:59:50 +0000
commit8b0250b32b89a54df16989369c0cb8330d86cb77 (patch)
treee55259c6fedd23af7998650726ff759cac90afb3 /util/flashrom_tester/flashrom/src/lib.rs
parentff5beeef409515d0db84f1e902388590f5b15c44 (diff)
downloadflashrom-8b0250b32b89a54df16989369c0cb8330d86cb77.tar.gz
flashrom-8b0250b32b89a54df16989369c0cb8330d86cb77.tar.bz2
flashrom-8b0250b32b89a54df16989369c0cb8330d86cb77.zip
flashrom_tester: Drop dediprog, ec, and servo targets
None of these targets have been maintained or used for several years: dediprog: - Wasn't accepted by the argument filter in main.rs. ec: - Is incompatible with most tests because the EC only supports one protection range. servo: - Has been broken for >3 years because it uses the programmer string "ft2231_spi:type=servo-v2", where "ft2231" should be "ft2232". BUG=b:239357853 BRANCH=none TEST=flashrom_tester on dedede Change-Id: Iee94f6bb5ff8c5451acb8bcaabf28119006d0ef5 Signed-off-by: Nikolai Artemiev <nartemiev@google.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/69921 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Diffstat (limited to 'util/flashrom_tester/flashrom/src/lib.rs')
-rw-r--r--util/flashrom_tester/flashrom/src/lib.rs14
1 files changed, 2 insertions, 12 deletions
diff --git a/util/flashrom_tester/flashrom/src/lib.rs b/util/flashrom_tester/flashrom/src/lib.rs
index 90e40e2cc..6b0cca36e 100644
--- a/util/flashrom_tester/flashrom/src/lib.rs
+++ b/util/flashrom_tester/flashrom/src/lib.rs
@@ -41,7 +41,7 @@ mod flashromlib;
use std::{error, fmt, path::Path};
-pub use cmd::{dut_ctrl_toggle_wp, FlashromCmd};
+pub use cmd::FlashromCmd;
pub use flashromlib::FlashromLib;
pub use libflashrom::{
@@ -51,28 +51,19 @@ pub use libflashrom::{
#[derive(Copy, Clone, PartialEq, Eq, Debug)]
pub enum FlashChip {
- EC,
HOST,
- SERVO,
- DEDIPROG,
}
impl FlashChip {
pub fn from(s: &str) -> Result<FlashChip, &str> {
match s {
- "ec" => Ok(FlashChip::EC),
"host" => Ok(FlashChip::HOST),
- "servo" => Ok(FlashChip::SERVO),
- "dediprog" => Ok(FlashChip::DEDIPROG),
_ => Err("cannot convert str to enum"),
}
}
pub fn to(fc: FlashChip) -> &'static str {
match fc {
- FlashChip::EC => "ec",
FlashChip::HOST => "host",
- FlashChip::SERVO => "ft2231_spi:type=servo-v2",
- FlashChip::DEDIPROG => "dediprog",
}
}
@@ -89,8 +80,7 @@ impl FlashChip {
/// disabled.
pub fn can_control_hw_wp(&self) -> bool {
match self {
- FlashChip::HOST | FlashChip::EC => true,
- FlashChip::SERVO | FlashChip::DEDIPROG => false,
+ FlashChip::HOST => true,
}
}
}