diff options
| author | Colin Ian King <colin.king@canonical.com> | 2019-05-10 22:06:38 -0400 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2020-06-11 19:05:54 +0100 |
| commit | 310dac05e090433b1de043eff9d0b0c389ba843f (patch) | |
| tree | 2a324600f5edf8ca42847fb71716c76ac32fc40d | |
| parent | 51890201da4d654f6ca131bc45a0e892bb10de1d (diff) | |
| download | linux-stable-310dac05e090433b1de043eff9d0b0c389ba843f.tar.gz linux-stable-310dac05e090433b1de043eff9d0b0c389ba843f.tar.bz2 linux-stable-310dac05e090433b1de043eff9d0b0c389ba843f.zip | |
ext4: unsigned int compared against zero
commit fbbbbd2f28aec991f3fbc248df211550fbdfd58c upstream.
There are two cases where u32 variables n and err are being checked
for less than zero error values, the checks is always false because
the variables are not signed. Fix this by making the variables ints.
Addresses-Coverity: ("Unsigned compared against 0")
Fixes: 345c0dbf3a30 ("ext4: protect journal inode's blocks using block_validity")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
| -rw-r--r-- | fs/ext4/block_validity.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/ext4/block_validity.c b/fs/ext4/block_validity.c index afa29592d0cc..f4f805989beb 100644 --- a/fs/ext4/block_validity.c +++ b/fs/ext4/block_validity.c @@ -142,7 +142,8 @@ static int ext4_protect_reserved_inode(struct super_block *sb, u32 ino) struct inode *inode; struct ext4_sb_info *sbi = EXT4_SB(sb); struct ext4_map_blocks map; - u32 i = 0, err = 0, num, n; + u32 i = 0, num; + int err = 0, n; if ((ino < EXT4_ROOT_INO) || (ino > le32_to_cpu(sbi->s_es->s_inodes_count))) |