diff options
| author | Vladis Dronov <vdronov@redhat.com> | 2015-12-24 11:09:41 -0500 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2020-06-11 19:05:39 +0100 |
| commit | 976dc007c4fde824b46cd40d001a17734ce9e333 (patch) | |
| tree | 964dd7a4968a4209da7de94e956b9088f6d51049 | |
| parent | b122516be7a9cccceb48dc7ee6ff1717b39e6ae2 (diff) | |
| download | linux-stable-976dc007c4fde824b46cd40d001a17734ce9e333.tar.gz linux-stable-976dc007c4fde824b46cd40d001a17734ce9e333.tar.bz2 linux-stable-976dc007c4fde824b46cd40d001a17734ce9e333.zip | |
selinux: rate-limit netlink message warnings in selinux_nlmsg_perm()
commit 76319946f321e30872dd72af7de867cb26e7a373 upstream.
Any process is able to send netlink messages with invalid types.
Make the warning rate-limited to prevent too much log spam.
The warning is supposed to help to find misbehaving programs, so
print the triggering command name and pid.
Reported-by: Florian Weimer <fweimer@redhat.com>
Signed-off-by: Vladis Dronov <vdronov@redhat.com>
[PM: subject line tweak to make checkpatch.pl happy]
Signed-off-by: Paul Moore <pmoore@redhat.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
| -rw-r--r-- | security/selinux/hooks.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c index 99814b6807c4..5b8353183cd1 100644 --- a/security/selinux/hooks.c +++ b/security/selinux/hooks.c @@ -4683,11 +4683,12 @@ static int selinux_nlmsg_perm(struct sock *sk, struct sk_buff *skb) err = selinux_nlmsg_lookup(sksec->sclass, nlh->nlmsg_type, &perm); if (err) { if (err == -EINVAL) { - printk(KERN_WARNING - "SELinux: unrecognized netlink message:" - " protocol=%hu nlmsg_type=%hu sclass=%s\n", + pr_warn_ratelimited("SELinux: unrecognized netlink" + " message: protocol=%hu nlmsg_type=%hu sclass=%s" + " pig=%d comm=%s\n", sk->sk_protocol, nlh->nlmsg_type, - secclass_map[sksec->sclass - 1].name); + secclass_map[sksec->sclass - 1].name, + task_pid_nr(current), current->comm); if (!selinux_enforcing || security_get_allow_unknown()) err = 0; } |