summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDmitry Torokhov <dmitry.torokhov@gmail.com>2015-08-06 19:15:30 -0700
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2018-02-07 11:07:53 -0800
commit33fd368597ad615f9f7232ca9daa3ed3fdba1516 (patch)
treed548c131ae0d1c2ba45fba4d8a89a923a81de43e
parent90aaf2f25609f99b63fcbed280716f80b4bc5f56 (diff)
downloadlinux-stable-33fd368597ad615f9f7232ca9daa3ed3fdba1516.tar.gz
linux-stable-33fd368597ad615f9f7232ca9daa3ed3fdba1516.tar.bz2
linux-stable-33fd368597ad615f9f7232ca9daa3ed3fdba1516.zip
Input: do not emit unneeded EV_SYN when suspending
commit 00159f19a5057cb779146afce1cceede692af346 upstream. Do not emit EV_SYN/SYN_REPORT on suspend if there were no keys that are still pressed as we are suspending the device (and in all other cases when input core is forcibly releasing keys via input_dev_release_keys() call). Reviewed-by: Benson Leung <bleung@chromium.org> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Signed-off-by: Bo Hu <bohu@google.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/input/input.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/input/input.c b/drivers/input/input.c
index 0f175f55782b..34aae7e5498a 100644
--- a/drivers/input/input.c
+++ b/drivers/input/input.c
@@ -668,6 +668,7 @@ EXPORT_SYMBOL(input_close_device);
*/
static void input_dev_release_keys(struct input_dev *dev)
{
+ bool need_sync = false;
int code;
if (is_event_supported(EV_KEY, dev->evbit, EV_MAX)) {
@@ -675,9 +676,11 @@ static void input_dev_release_keys(struct input_dev *dev)
if (is_event_supported(code, dev->keybit, KEY_MAX) &&
__test_and_clear_bit(code, dev->key)) {
input_pass_event(dev, EV_KEY, code, 0);
+ need_sync = true;
}
}
- input_pass_event(dev, EV_SYN, SYN_REPORT, 1);
+ if (need_sync)
+ input_pass_event(dev, EV_SYN, SYN_REPORT, 1);
}
}