summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHangyu Hua <hbh25y@gmail.com>2023-12-21 10:25:31 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2024-01-10 14:45:40 +0100
commit5afbb60ffdbe648be5fa722b0802a38f38cec4de (patch)
treed2476387ced820f813f1f636f421c97794297fec
parent83724831dab1df80d4b6e33986a1a8307a89ebf1 (diff)
downloadlinux-stable-5afbb60ffdbe648be5fa722b0802a38f38cec4de.tar.gz
linux-stable-5afbb60ffdbe648be5fa722b0802a38f38cec4de.tar.bz2
linux-stable-5afbb60ffdbe648be5fa722b0802a38f38cec4de.zip
net: sched: em_text: fix possible memory leak in em_text_destroy()
[ Upstream commit 8fcb0382af6f1ef50936f1be05b8149eb2f88496 ] m->data needs to be freed when em_text_destroy is called. Fixes: d675c989ed2d ("[PKT_SCHED]: Packet classification based on textsearch (ematch)") Acked-by: Jamal Hadi Salim <jhs@mojatatu.com> Signed-off-by: Hangyu Hua <hbh25y@gmail.com> Reviewed-by: Simon Horman <horms@kernel.org> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>
-rw-r--r--net/sched/em_text.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/net/sched/em_text.c b/net/sched/em_text.c
index 73e2ed576ceb..cbf44783024f 100644
--- a/net/sched/em_text.c
+++ b/net/sched/em_text.c
@@ -101,8 +101,10 @@ retry:
static void em_text_destroy(struct tcf_ematch *m)
{
- if (EM_TEXT_PRIV(m) && EM_TEXT_PRIV(m)->config)
+ if (EM_TEXT_PRIV(m) && EM_TEXT_PRIV(m)->config) {
textsearch_destroy(EM_TEXT_PRIV(m)->config);
+ kfree(EM_TEXT_PRIV(m));
+ }
}
static int em_text_dump(struct sk_buff *skb, struct tcf_ematch *m)