summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYan Lei <yan_lei@dahuatech.com>2022-04-10 07:19:25 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2023-01-18 11:30:36 +0100
commitb4d8fd008de1774d99a5b50acc03d92a1919c3a7 (patch)
treeea3f01df4f156df85c0008dc6b9aed1ba94aedd6
parentc2a698ff156974908308f42cf5991ab5c0c4b8cd (diff)
downloadlinux-stable-b4d8fd008de1774d99a5b50acc03d92a1919c3a7.tar.gz
linux-stable-b4d8fd008de1774d99a5b50acc03d92a1919c3a7.tar.bz2
linux-stable-b4d8fd008de1774d99a5b50acc03d92a1919c3a7.zip
media: dvb-frontends: fix leak of memory fw
[ Upstream commit a15fe8d9f1bf460a804bcf18a890bfd2cf0d5caa ] Link: https://lore.kernel.org/linux-media/20220410061925.4107-1-chinayanlei2002@163.com Signed-off-by: Yan Lei <yan_lei@dahuatech.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
-rw-r--r--drivers/media/dvb-frontends/bcm3510.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/media/dvb-frontends/bcm3510.c b/drivers/media/dvb-frontends/bcm3510.c
index e92542b92d34..6457b0912d14 100644
--- a/drivers/media/dvb-frontends/bcm3510.c
+++ b/drivers/media/dvb-frontends/bcm3510.c
@@ -649,6 +649,7 @@ static int bcm3510_download_firmware(struct dvb_frontend* fe)
deb_info("firmware chunk, addr: 0x%04x, len: 0x%04x, total length: 0x%04zx\n",addr,len,fw->size);
if ((ret = bcm3510_write_ram(st,addr,&b[i+4],len)) < 0) {
err("firmware download failed: %d\n",ret);
+ release_firmware(fw);
return ret;
}
i += 4 + len;