diff options
| author | Samasth Norway Ananda <samasth.norway.ananda@oracle.com> | 2024-02-13 16:19:56 -0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-04-13 12:50:15 +0200 |
| commit | c4f135f454deb2ff4b7a5ec53577aaa776e2fac9 (patch) | |
| tree | 60a4f2464f75afe8fff80b7b8239166472c9a03d | |
| parent | 23c6f9f6619a699c196cfc1e5a57becdfe4a0b9a (diff) | |
| download | linux-stable-c4f135f454deb2ff4b7a5ec53577aaa776e2fac9.tar.gz linux-stable-c4f135f454deb2ff4b7a5ec53577aaa776e2fac9.tar.bz2 linux-stable-c4f135f454deb2ff4b7a5ec53577aaa776e2fac9.zip | |
tools/power x86_energy_perf_policy: Fix file leak in get_pkg_num()
[ Upstream commit f85450f134f0b4ca7e042dc3dc89155656a2299d ]
In function get_pkg_num() if fopen_or_die() succeeds it returns a file
pointer to be used. But fclose() is never called before returning from
the function.
Signed-off-by: Samasth Norway Ananda <samasth.norway.ananda@oracle.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c b/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c index 2aba622d1c5a..470d03e14342 100644 --- a/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c +++ b/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c @@ -1112,6 +1112,7 @@ unsigned int get_pkg_num(int cpu) retval = fscanf(fp, "%d\n", &pkg); if (retval != 1) errx(1, "%s: failed to parse", pathname); + fclose(fp); return pkg; } |