diff options
| author | Mauro Carvalho Chehab <mchehab+samsung@kernel.org> | 2019-03-28 14:36:14 -0400 |
|---|---|---|
| committer | Sasha Levin <sashal@kernel.org> | 2024-03-26 18:22:38 -0400 |
| commit | cfa5ffc57e54fb8b864d23b6992cb37d706f6a87 (patch) | |
| tree | 2b243af0fa78e46d819e0e456a8b11e953183f9d | |
| parent | 3dd8abb0ed0e0a7c66d6d677c86ccb188cc39333 (diff) | |
| download | linux-stable-cfa5ffc57e54fb8b864d23b6992cb37d706f6a87.tar.gz linux-stable-cfa5ffc57e54fb8b864d23b6992cb37d706f6a87.tar.bz2 linux-stable-cfa5ffc57e54fb8b864d23b6992cb37d706f6a87.zip | |
media: dvbdev: remove double-unlock
[ Upstream commit 122d0e8dd050cc5dc3fb9e9b5f2dee3c5276ce35 ]
As warned by smatch:
drivers/media/dvb-core/dvbdev.c: drivers/media/dvb-core/dvbdev.c:529 dvb_register_device() error: double unlock 'sem:&minor_rwsem'
Reported-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Stable-dep-of: 8c64f4cdf4e6 ("media: edia: dvbdev: fix a use-after-free")
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/media/dvb-core/dvbdev.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/media/dvb-core/dvbdev.c b/drivers/media/dvb-core/dvbdev.c index b8335ede6626..1f80c4fa31c9 100644 --- a/drivers/media/dvb-core/dvbdev.c +++ b/drivers/media/dvb-core/dvbdev.c @@ -536,7 +536,6 @@ int dvb_register_device(struct dvb_adapter *adap, struct dvb_device **pdvbdev, dvb_media_device_free(dvbdev); kfree(dvbdevfops); kfree(dvbdev); - up_write(&minor_rwsem); mutex_unlock(&dvbdev_register_lock); return ret; } |