diff options
author | Jann Horn <jannh@google.com> | 2016-06-01 11:55:07 +0200 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-06-24 10:18:20 -0700 |
commit | c08b1a593a042ae01e788ec5504bee2cfc83e1f2 (patch) | |
tree | 3e175f87b549fa0f2487002fafca71c3eca74003 | |
parent | 9beb96b344c846779f67d1be1cdafc66562b94ec (diff) | |
download | linux-stable-c08b1a593a042ae01e788ec5504bee2cfc83e1f2.tar.gz linux-stable-c08b1a593a042ae01e788ec5504bee2cfc83e1f2.tar.bz2 linux-stable-c08b1a593a042ae01e788ec5504bee2cfc83e1f2.zip |
sched: panic on corrupted stack end
commit 29d6455178a09e1dc340380c582b13356227e8df upstream.
Until now, hitting this BUG_ON caused a recursive oops (because oops
handling involves do_exit(), which calls into the scheduler, which in
turn raises an oops), which caused stuff below the stack to be
overwritten until a panic happened (e.g. via an oops in interrupt
context, caused by the overwritten CPU index in the thread_info).
Just panic directly.
Signed-off-by: Jann Horn <jannh@google.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | kernel/sched/core.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 55bebf924946..6c0cdb5a73f8 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -3008,7 +3008,8 @@ static noinline void __schedule_bug(struct task_struct *prev) static inline void schedule_debug(struct task_struct *prev) { #ifdef CONFIG_SCHED_STACK_END_CHECK - BUG_ON(task_stack_end_corrupted(prev)); + if (task_stack_end_corrupted(prev)) + panic("corrupted stack end detected inside scheduler\n"); #endif if (unlikely(in_atomic_preempt_off())) { |