summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYuan Can <yuancan@huawei.com>2022-11-21 08:20:22 +0000
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2023-01-07 12:07:28 +0100
commitc93983230562883e0b5f122040efbb3d478c36d4 (patch)
treecc81e6845ed45081e037034b07385c10498f1d74
parent4be1a8d894d3212b62e549bcc72af0e1870291d1 (diff)
downloadlinux-stable-c93983230562883e0b5f122040efbb3d478c36d4.tar.gz
linux-stable-c93983230562883e0b5f122040efbb3d478c36d4.tar.bz2
linux-stable-c93983230562883e0b5f122040efbb3d478c36d4.zip
iommu/fsl_pamu: Fix resource leak in fsl_pamu_probe()
[ Upstream commit 73f5fc5f884ad0c5f7d57f66303af64f9f002526 ] The fsl_pamu_probe() returns directly when create_csd() failed, leaving irq and memories unreleased. Fix by jumping to error if create_csd() returns error. Fixes: 695093e38c3e ("iommu/fsl: Freescale PAMU driver and iommu implementation.") Signed-off-by: Yuan Can <yuancan@huawei.com> Link: https://lore.kernel.org/r/20221121082022.19091-1-yuancan@huawei.com Signed-off-by: Joerg Roedel <jroedel@suse.de> Signed-off-by: Sasha Levin <sashal@kernel.org>
-rw-r--r--drivers/iommu/fsl_pamu.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/iommu/fsl_pamu.c b/drivers/iommu/fsl_pamu.c
index a34355fca37a..4d6bdc465dde 100644
--- a/drivers/iommu/fsl_pamu.c
+++ b/drivers/iommu/fsl_pamu.c
@@ -1131,7 +1131,7 @@ static int fsl_pamu_probe(struct platform_device *pdev)
ret = create_csd(ppaact_phys, mem_size, csd_port_id);
if (ret) {
dev_err(dev, "could not create coherence subdomain\n");
- return ret;
+ goto error;
}
}