diff options
| author | Colin Ian King <colin.king@canonical.com> | 2018-07-05 12:05:25 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-07-05 20:07:40 +0900 |
| commit | 4ed88df766704633459d8fddce1c1c87e1acb844 (patch) | |
| tree | 6b56b4cbfb80be933a4c4095ebd4748c4c7f9aae | |
| parent | 2727eac605bb4787ae43eff6e022196f5297e329 (diff) | |
| download | linux-stable-4ed88df766704633459d8fddce1c1c87e1acb844.tar.gz linux-stable-4ed88df766704633459d8fddce1c1c87e1acb844.tar.bz2 linux-stable-4ed88df766704633459d8fddce1c1c87e1acb844.zip | |
net: ethernet: sun: remove redundant variables adv and lpa and mii_reads
Variables adv and lpa are being assigned but are never used hence they
are redundant and can be removed. Also remove the unncessary mii_reads
too.
Cleans up clang warnings:
warning: variable 'lpa' set but not used [-Wunused-but-set-variable]
warning: variable 'adv' set but not used [-Wunused-but-set-variable]
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/sun/niu.c | 16 |
1 files changed, 0 insertions, 16 deletions
diff --git a/drivers/net/ethernet/sun/niu.c b/drivers/net/ethernet/sun/niu.c index 88c12474a0c3..9319d84bf49f 100644 --- a/drivers/net/ethernet/sun/niu.c +++ b/drivers/net/ethernet/sun/niu.c @@ -1225,25 +1225,9 @@ static int link_status_1g_rgmii(struct niu *np, int *link_up_p) bmsr = err; if (bmsr & BMSR_LSTATUS) { - u16 adv, lpa; - - err = mii_read(np, np->phy_addr, MII_ADVERTISE); - if (err < 0) - goto out; - adv = err; - - err = mii_read(np, np->phy_addr, MII_LPA); - if (err < 0) - goto out; - lpa = err; - - err = mii_read(np, np->phy_addr, MII_ESTATUS); - if (err < 0) - goto out; link_up = 1; current_speed = SPEED_1000; current_duplex = DUPLEX_FULL; - } lp->active_speed = current_speed; lp->active_duplex = current_duplex; |