summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLinus Walleij <linus.walleij@linaro.org>2015-08-04 16:21:49 +0200
committerJonathan Cameron <jic23@kernel.org>2015-08-12 19:26:22 +0100
commitaf255cd562aaa72455f9022a26afacd68f3fbf73 (patch)
tree0566e2687e90c95bed3c8fdd69b3d82e817207c9
parent06d2f6ca5a38abe92f1f3a132b331eee773868c3 (diff)
downloadlinux-stable-af255cd562aaa72455f9022a26afacd68f3fbf73.tar.gz
linux-stable-af255cd562aaa72455f9022a26afacd68f3fbf73.tar.bz2
linux-stable-af255cd562aaa72455f9022a26afacd68f3fbf73.zip
iio: lsiio: fix error code handling error
commit acf50b3586f8d8a7530b905e111dda41876d38f4 "tools:iio:lsiio: add error handling" introduced error handling of errors returned from read_sysfs_string(), but with a simple if (retval), missing the fact that these functions return a positive value if the read was successful. As a result lsiio regresses and does not show any devices on my filesystem. Fix this by checking for only negative error codes. Cc: Hartmut Knaack <knaack.h@gmx.de> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Acked-by: Hartmut Knaack <knaack.h@gmx.de> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
-rw-r--r--tools/iio/lsiio.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/iio/lsiio.c b/tools/iio/lsiio.c
index b271a9a796d2..3d650e668252 100644
--- a/tools/iio/lsiio.c
+++ b/tools/iio/lsiio.c
@@ -69,7 +69,7 @@ static int dump_one_device(const char *dev_dir_name)
return -EINVAL;
ret = read_sysfs_string("name", dev_dir_name, name);
- if (ret)
+ if (ret < 0)
return ret;
printf("Device %03d: %s\n", dev_idx, name);
@@ -92,7 +92,7 @@ static int dump_one_trigger(const char *dev_dir_name)
return -EINVAL;
ret = read_sysfs_string("name", dev_dir_name, name);
- if (ret)
+ if (ret < 0)
return ret;
printf("Trigger %03d: %s\n", dev_idx, name);