summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMaximilian Luz <luzmaximilian@gmail.com>2021-05-12 11:08:15 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2021-05-19 10:29:54 +0200
commit439baba2e32195b3822dddd0410b19e01ad95aa5 (patch)
treef13ee570efb3b0a58c54e5e0a49d61825a3c92ec
parentcf8cf47b0b6ec59ad5b1ca01317642a8389f20dd (diff)
downloadlinux-stable-439baba2e32195b3822dddd0410b19e01ad95aa5.tar.gz
linux-stable-439baba2e32195b3822dddd0410b19e01ad95aa5.tar.bz2
linux-stable-439baba2e32195b3822dddd0410b19e01ad95aa5.zip
usb: xhci: Increase timeout for HC halt
commit ca09b1bea63ab83f4cca3a2ae8bc4f597ec28851 upstream. On some devices (specifically the SC8180x based Surface Pro X with QCOM04A6) HC halt / xhci_halt() times out during boot. Manually binding the xhci-hcd driver at some point later does not exhibit this behavior. To work around this, double XHCI_MAX_HALT_USEC, which also resolves this issue. Cc: <stable@vger.kernel.org> Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com> Link: https://lore.kernel.org/r/20210512080816.866037-5-mathias.nyman@linux.intel.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/usb/host/xhci-ext-caps.h5
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/usb/host/xhci-ext-caps.h b/drivers/usb/host/xhci-ext-caps.h
index fa59b242cd51..e8af0a125f84 100644
--- a/drivers/usb/host/xhci-ext-caps.h
+++ b/drivers/usb/host/xhci-ext-caps.h
@@ -7,8 +7,9 @@
* Author: Sarah Sharp
* Some code borrowed from the Linux EHCI driver.
*/
-/* Up to 16 ms to halt an HC */
-#define XHCI_MAX_HALT_USEC (16*1000)
+
+/* HC should halt within 16 ms, but use 32 ms as some hosts take longer */
+#define XHCI_MAX_HALT_USEC (32 * 1000)
/* HC not running - set to 1 when run/stop bit is cleared. */
#define XHCI_STS_HALT (1<<0)