diff options
| author | Philipp Zabel <p.zabel@pengutronix.de> | 2021-06-07 10:26:15 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-07-20 16:02:25 +0200 |
| commit | 6fa600fbd43738a7982ed5fc447451b1c98f3039 (patch) | |
| tree | 49bedfec12a5aa54f59da8a2ce63c6bb68fe1f50 | |
| parent | bb30cbbf0de0241310bf6529253f103024cadb26 (diff) | |
| download | linux-stable-6fa600fbd43738a7982ed5fc447451b1c98f3039.tar.gz linux-stable-6fa600fbd43738a7982ed5fc447451b1c98f3039.tar.bz2 linux-stable-6fa600fbd43738a7982ed5fc447451b1c98f3039.zip | |
reset: bail if try_module_get() fails
[ Upstream commit 4fb26fb83f0def3d39c14e268bcd4003aae8fade ]
Abort instead of returning a new reset control for a reset controller
device that is going to have its module unloaded.
Reported-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Fixes: 61fc41317666 ("reset: Add reset controller API")
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20210607082615.15160-1-p.zabel@pengutronix.de
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/reset/core.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/reset/core.c b/drivers/reset/core.c index dbf881b586d9..fd7e1a3525f4 100644 --- a/drivers/reset/core.c +++ b/drivers/reset/core.c @@ -640,7 +640,10 @@ static struct reset_control *__reset_control_get_internal( if (!rstc) return ERR_PTR(-ENOMEM); - try_module_get(rcdev->owner); + if (!try_module_get(rcdev->owner)) { + kfree(rstc); + return ERR_PTR(-ENODEV); + } rstc->rcdev = rcdev; list_add(&rstc->list, &rcdev->reset_control_head); |