diff options
| author | Jia-Ju Bai <baijiaju1990@gmail.com> | 2019-07-23 18:00:15 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-10-07 18:59:33 +0200 |
| commit | 88b4b5b7e2a89146ba2738d8ed0093150a4f0138 (patch) | |
| tree | 5fb7e1792c958a1c90b55ee5a5787e8b6eb32cbf | |
| parent | 0728352751bbefc04a68150d82f84fe145eac2ce (diff) | |
| download | linux-stable-88b4b5b7e2a89146ba2738d8ed0093150a4f0138.tar.gz linux-stable-88b4b5b7e2a89146ba2738d8ed0093150a4f0138.tar.bz2 linux-stable-88b4b5b7e2a89146ba2738d8ed0093150a4f0138.zip | |
security: smack: Fix possible null-pointer dereferences in smack_socket_sock_rcv_skb()
[ Upstream commit 3f4287e7d98a2954f20bf96c567fdffcd2b63eb9 ]
In smack_socket_sock_rcv_skb(), there is an if statement
on line 3920 to check whether skb is NULL:
if (skb && skb->secmark != 0)
This check indicates skb can be NULL in some cases.
But on lines 3931 and 3932, skb is used:
ad.a.u.net->netif = skb->skb_iif;
ipv6_skb_to_auditdata(skb, &ad.a, NULL);
Thus, possible null-pointer dereferences may occur when skb is NULL.
To fix these possible bugs, an if statement is added to check skb.
These bugs are found by a static analysis tool STCheck written by us.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | security/smack/smack_lsm.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c index 4c5e5a438f8b..5c9fc8ba6e57 100644 --- a/security/smack/smack_lsm.c +++ b/security/smack/smack_lsm.c @@ -3925,6 +3925,8 @@ access_check: skp = smack_ipv6host_label(&sadd); if (skp == NULL) skp = smack_net_ambient; + if (skb == NULL) + break; #ifdef CONFIG_AUDIT smk_ad_init_net(&ad, __func__, LSM_AUDIT_DATA_NET, &net); ad.a.u.net->family = family; |