summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJan Kara <jack@suse.cz>2019-05-23 23:35:28 -0400
committerTheodore Ts'o <tytso@mit.edu>2019-05-23 23:35:28 -0400
commitee0ed02ca93ef1ecf8963ad96638795d55af2c14 (patch)
treed466f5a61e165caf2a4a70b27234d448a361664d
parent82a25b027ca48d7ef197295846b352345853dfa8 (diff)
downloadlinux-stable-ee0ed02ca93ef1ecf8963ad96638795d55af2c14.tar.gz
linux-stable-ee0ed02ca93ef1ecf8963ad96638795d55af2c14.tar.bz2
linux-stable-ee0ed02ca93ef1ecf8963ad96638795d55af2c14.zip
ext4: do not delete unlinked inode from orphan list on failed truncate
It is possible that unlinked inode enters ext4_setattr() (e.g. if somebody calls ftruncate(2) on unlinked but still open file). In such case we should not delete the inode from the orphan list if truncate fails. Note that this is mostly a theoretical concern as filesystem is corrupted if we reach this path anyway but let's be consistent in our orphan handling. Reviewed-by: Ira Weiny <ira.weiny@intel.com> Signed-off-by: Jan Kara <jack@suse.cz> Signed-off-by: Theodore Ts'o <tytso@mit.edu> Cc: stable@kernel.org
-rw-r--r--fs/ext4/inode.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 9bcb7f2b86dd..c7f77c643008 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -5625,7 +5625,7 @@ int ext4_setattr(struct dentry *dentry, struct iattr *attr)
up_write(&EXT4_I(inode)->i_data_sem);
ext4_journal_stop(handle);
if (error) {
- if (orphan)
+ if (orphan && inode->i_nlink)
ext4_orphan_del(NULL, inode);
goto err_out;
}