summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMing Lei <ming.lei@redhat.com>2019-11-04 16:26:53 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-12-17 20:08:36 +0100
commite484f55479c49b871d882a2da84ac0abcfa6d1ad (patch)
treeffe0fcd35f1fce41ad8d26c67929fe7e45af1491
parente880a8445950c53e52891fef0df2ece918a2fba8 (diff)
downloadlinux-stable-e484f55479c49b871d882a2da84ac0abcfa6d1ad.tar.gz
linux-stable-e484f55479c49b871d882a2da84ac0abcfa6d1ad.tar.bz2
linux-stable-e484f55479c49b871d882a2da84ac0abcfa6d1ad.zip
blk-mq: make sure that line break can be printed
commit d2c9be89f8ebe7ebcc97676ac40f8dec1cf9b43a upstream. 8962842ca5ab ("blk-mq: avoid sysfs buffer overflow with too many CPU cores") avoids sysfs buffer overflow, and reserves one character for line break. However, the last snprintf() doesn't get correct 'size' parameter passed in, so fixed it. Fixes: 8962842ca5ab ("blk-mq: avoid sysfs buffer overflow with too many CPU cores") Signed-off-by: Ming Lei <ming.lei@redhat.com> Signed-off-by: Jens Axboe <axboe@kernel.dk> Cc: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--block/blk-mq-sysfs.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/block/blk-mq-sysfs.c b/block/blk-mq-sysfs.c
index 7389311e28f8..3a8e653eea77 100644
--- a/block/blk-mq-sysfs.c
+++ b/block/blk-mq-sysfs.c
@@ -183,7 +183,7 @@ static ssize_t blk_mq_hw_sysfs_cpus_show(struct blk_mq_hw_ctx *hctx, char *page)
pos += ret;
}
- ret = snprintf(pos + page, size - pos, "\n");
+ ret = snprintf(pos + page, size + 1 - pos, "\n");
return pos + ret;
}