diff options
| author | Jianguo Wu <wujianguo@chinatelecom.cn> | 2020-12-05 15:56:33 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-12-21 13:28:16 +0100 |
| commit | a2b36c25055b08855b9aa3e3dc5b23edf6d9d369 (patch) | |
| tree | 0d14137ca523411f798e159a213e793e1d216c54 | |
| parent | ebee7afaec098c0bca293d3f7fc5b733d9a77e62 (diff) | |
| download | linux-stable-a2b36c25055b08855b9aa3e3dc5b23edf6d9d369.tar.gz linux-stable-a2b36c25055b08855b9aa3e3dc5b23edf6d9d369.tar.bz2 linux-stable-a2b36c25055b08855b9aa3e3dc5b23edf6d9d369.zip | |
mptcp: print new line in mptcp_seq_show() if mptcp isn't in use
[ Upstream commit f55628b3e7648198e9c072b52080c5dea8678adf ]
When do cat /proc/net/netstat, the output isn't append with a new line, it looks like this:
[root@localhost ~]# cat /proc/net/netstat
...
MPTcpExt: 0 0 0 0 0 0 0 0 0 0 0 0 0[root@localhost ~]#
This is because in mptcp_seq_show(), if mptcp isn't in use, net->mib.mptcp_statistics is NULL,
so it just puts all 0 after "MPTcpExt:", and return, forgot the '\n'.
After this patch:
[root@localhost ~]# cat /proc/net/netstat
...
MPTcpExt: 0 0 0 0 0 0 0 0 0 0 0 0 0
[root@localhost ~]#
Fixes: fc518953bc9c8d7d ("mptcp: add and use MIB counter infrastructure")
Signed-off-by: Jianguo Wu <wujianguo@chinatelecom.cn>
Acked-by: Florian Westphal <fw@strlen.de>
Link: https://lore.kernel.org/r/142e2fd9-58d9-bb13-fb75-951cccc2331e@163.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | net/mptcp/mib.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/mptcp/mib.c b/net/mptcp/mib.c index 0a6a15f3456d..49fca22aaba3 100644 --- a/net/mptcp/mib.c +++ b/net/mptcp/mib.c @@ -58,6 +58,7 @@ void mptcp_seq_show(struct seq_file *seq) for (i = 0; mptcp_snmp_list[i].name; i++) seq_puts(seq, " 0"); + seq_putc(seq, '\n'); return; } |