summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNamjae Jeon <linkinjeon@kernel.org>2024-04-19 23:46:34 +0900
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2024-04-27 17:13:04 +0200
commitb45259d419d682ec26351eda34395e306bd05253 (patch)
tree0201b124775060daf07d45153de8218f6aca1ce8
parentaaf8d12ac16680c6b22de087e78fb6a30908cda3 (diff)
downloadlinux-stable-b45259d419d682ec26351eda34395e306bd05253.tar.gz
linux-stable-b45259d419d682ec26351eda34395e306bd05253.tar.bz2
linux-stable-b45259d419d682ec26351eda34395e306bd05253.zip
ksmbd: common: use struct_group_attr instead of struct_group for network_open_info
commit 0268a7cc7fdc47d90b6c18859de7718d5059f6f1 upstream. 4byte padding cause the connection issue with the applications of MacOS. smb2_close response size increases by 4 bytes by padding, And the smb client of MacOS check it and stop the connection. This patch use struct_group_attr instead of struct_group for network_open_info to use __packed to avoid padding. Fixes: 0015eb6e1238 ("smb: client, common: fix fortify warnings") Cc: stable@vger.kernel.org Signed-off-by: Namjae Jeon <linkinjeon@kernel.org> Signed-off-by: Steve French <stfrench@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--fs/smb/common/smb2pdu.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/smb/common/smb2pdu.h b/fs/smb/common/smb2pdu.h
index 57f2343164a3..a233a24352b1 100644
--- a/fs/smb/common/smb2pdu.h
+++ b/fs/smb/common/smb2pdu.h
@@ -702,7 +702,7 @@ struct smb2_close_rsp {
__le16 StructureSize; /* 60 */
__le16 Flags;
__le32 Reserved;
- struct_group(network_open_info,
+ struct_group_attr(network_open_info, __packed,
__le64 CreationTime;
__le64 LastAccessTime;
__le64 LastWriteTime;