diff options
| author | Jan Kara <jack@suse.cz> | 2009-07-22 13:17:16 +0200 |
|---|---|---|
| committer | Joel Becker <joel.becker@oracle.com> | 2009-07-23 10:59:05 -0700 |
| commit | 4b3fa1904c0d192461ebba692e4940a334b74353 (patch) | |
| tree | f95a515b92fed5072b82b4848f469214d8a9d90f | |
| parent | b57ac2c43e66cb4aa76c9d2d0e9e0e04f19cc5a6 (diff) | |
| download | linux-stable-4b3fa1904c0d192461ebba692e4940a334b74353.tar.gz linux-stable-4b3fa1904c0d192461ebba692e4940a334b74353.tar.bz2 linux-stable-4b3fa1904c0d192461ebba692e4940a334b74353.zip | |
ocfs2: Mark buffer uptodate before calling ocfs2_journal_access_dq()
In a code path extending local quota files we marked new header
buffer uptodate only after calling ocfs2_journal_access_dq() which
triggers a bug. Fix it and also call ocfs2 variant of the function
marking buffer uptodate.
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Joel Becker <joel.becker@oracle.com>
| -rw-r--r-- | fs/ocfs2/quota_local.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/fs/ocfs2/quota_local.c b/fs/ocfs2/quota_local.c index 5a460fa82553..b624f9bc9281 100644 --- a/fs/ocfs2/quota_local.c +++ b/fs/ocfs2/quota_local.c @@ -20,6 +20,7 @@ #include "sysfile.h" #include "dlmglue.h" #include "quota.h" +#include "uptodate.h" /* Number of local quota structures per block */ static inline unsigned int ol_quota_entries_per_block(struct super_block *sb) @@ -979,6 +980,8 @@ static struct ocfs2_quota_chunk *ocfs2_local_quota_add_chunk( mlog_errno(status); goto out; } + ocfs2_set_new_buffer_uptodate(lqinode, bh); + dchunk = (struct ocfs2_local_disk_chunk *)bh->b_data; handle = ocfs2_start_trans(OCFS2_SB(sb), 2); @@ -999,7 +1002,6 @@ static struct ocfs2_quota_chunk *ocfs2_local_quota_add_chunk( memset(dchunk->dqc_bitmap, 0, sb->s_blocksize - sizeof(struct ocfs2_local_disk_chunk) - OCFS2_QBLK_RESERVED_SPACE); - set_buffer_uptodate(bh); unlock_buffer(bh); status = ocfs2_journal_dirty(handle, bh); if (status < 0) { |