summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJean Delvare <khali@linux-fr.org>2009-11-16 12:45:39 +0100
committerGreg Kroah-Hartman <gregkh@suse.de>2009-12-08 10:22:29 -0800
commite3675ca0caa78b55d2c3d3bf5ef0e406c835cbd1 (patch)
tree509928d36d3f9b40761552835d305108590dc0a2
parentee3989464a4c4896ec29f5b1c2aae840fab8b73d (diff)
downloadlinux-stable-e3675ca0caa78b55d2c3d3bf5ef0e406c835cbd1.tar.gz
linux-stable-e3675ca0caa78b55d2c3d3bf5ef0e406c835cbd1.tar.bz2
linux-stable-e3675ca0caa78b55d2c3d3bf5ef0e406c835cbd1.zip
hwmon: (adt7475) Fix temperature fault flags
commit cf312e077662ec3a07529551ab6e885828ccfb1d upstream. The logic of temperature fault flags is wrong, it shows faults when there are none and vice versa. Fix it. I can't believe this has been broken since the driver was added, 8 months ago, basically breaking temp1 and temp3, and nobody ever complained. Signed-off-by: Jean Delvare <khali@linux-fr.org> Acked-by: Hans de Goede <hdegoede@redhat.com> Cc: Jordan Crouse <jordan@cosmicpenguin.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--drivers/hwmon/adt7475.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/hwmon/adt7475.c b/drivers/hwmon/adt7475.c
index d39877a7da63..d15819b4fe5f 100644
--- a/drivers/hwmon/adt7475.c
+++ b/drivers/hwmon/adt7475.c
@@ -350,8 +350,7 @@ static ssize_t show_temp(struct device *dev, struct device_attribute *attr,
case FAULT:
/* Note - only for remote1 and remote2 */
- out = data->alarms & (sattr->index ? 0x8000 : 0x4000);
- out = out ? 0 : 1;
+ out = !!(data->alarms & (sattr->index ? 0x8000 : 0x4000));
break;
default: