summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAdrian Wilkins <adrian.wilkins@nhs.net>2011-05-19 21:52:38 +0100
committerGreg Kroah-Hartman <gregkh@suse.de>2011-06-03 09:32:15 +0900
commiteff306d801588164b2763139ff98d57c3ba862aa (patch)
treeb378df5558c2237d32b033fda29bc7482386fdb6
parent1cb49cb8e35eaa4a1721ddad5ba0206ae6631db8 (diff)
downloadlinux-stable-eff306d801588164b2763139ff98d57c3ba862aa.tar.gz
linux-stable-eff306d801588164b2763139ff98d57c3ba862aa.tar.bz2
linux-stable-eff306d801588164b2763139ff98d57c3ba862aa.zip
ALSA: hda - Fix input-src parse in patch_analog.c
commit 5a2d227fdc7a02ed1b4cebba391d8fb9ad57caaf upstream. Compare pin type enum to the pin type and not the array index. Fixes bug#0005368. Signed-off-by: Adrian Wilkins <adrian.wilkins@nhs.net> Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--sound/pci/hda/patch_analog.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/sound/pci/hda/patch_analog.c b/sound/pci/hda/patch_analog.c
index 2942d2a9ea10..9f886bfc0590 100644
--- a/sound/pci/hda/patch_analog.c
+++ b/sound/pci/hda/patch_analog.c
@@ -3070,6 +3070,7 @@ static void ad1988_auto_init_analog_input(struct hda_codec *codec)
for (i = 0; i < cfg->num_inputs; i++) {
hda_nid_t nid = cfg->inputs[i].pin;
+ int type = cfg->inputs[i].type;
switch (nid) {
case 0x15: /* port-C */
snd_hda_codec_write(codec, 0x33, 0, AC_VERB_SET_CONNECT_SEL, 0x0);
@@ -3079,7 +3080,7 @@ static void ad1988_auto_init_analog_input(struct hda_codec *codec)
break;
}
snd_hda_codec_write(codec, nid, 0, AC_VERB_SET_PIN_WIDGET_CONTROL,
- i == AUTO_PIN_MIC ? PIN_VREF80 : PIN_IN);
+ type == AUTO_PIN_MIC ? PIN_VREF80 : PIN_IN);
if (nid != AD1988_PIN_CD_NID)
snd_hda_codec_write(codec, nid, 0, AC_VERB_SET_AMP_GAIN_MUTE,
AMP_OUT_MUTE);