summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLee Jones <lee.jones@linaro.org>2013-05-08 14:29:07 +0100
committerLinus Walleij <linus.walleij@linaro.org>2013-05-14 10:34:55 +0200
commit2fcad12eb4d80b174c69bfbc34d1c094ad37e1bd (patch)
tree6270d520607cde83b93dcee755cb32fb66c434af
parentf722406faae2d073cc1d01063d1123c35425939e (diff)
downloadlinux-stable-2fcad12eb4d80b174c69bfbc34d1c094ad37e1bd.tar.gz
linux-stable-2fcad12eb4d80b174c69bfbc34d1c094ad37e1bd.tar.bz2
linux-stable-2fcad12eb4d80b174c69bfbc34d1c094ad37e1bd.zip
pinctrl: abx500: Specify failed sub-driver by ID instead of driver_data
If a sub-driver has not been specified correctly, there is a good chance that plat_id is NULL, hence using an attribute of plat_id in the error message is likely to not only fail the driver but Oops the kernel. Use the failed ID instead. Signed-off-by: Lee Jones <lee.jones@linaro.org> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
-rw-r--r--drivers/pinctrl/pinctrl-abx500.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/pinctrl/pinctrl-abx500.c b/drivers/pinctrl/pinctrl-abx500.c
index aa17f7580f61..2a2a9df90bba 100644
--- a/drivers/pinctrl/pinctrl-abx500.c
+++ b/drivers/pinctrl/pinctrl-abx500.c
@@ -900,8 +900,7 @@ static int abx500_gpio_probe(struct platform_device *pdev)
abx500_pinctrl_ab8505_init(&pct->soc);
break;
default:
- dev_err(&pdev->dev, "Unsupported pinctrl sub driver (%d)\n",
- (int) platid->driver_data);
+ dev_err(&pdev->dev, "Unsupported pinctrl sub driver (%d)\n", id);
mutex_destroy(&pct->lock);
return -EINVAL;
}