diff options
| author | Fabio Estevam <fabio.estevam@nxp.com> | 2016-11-05 17:45:07 -0200 |
|---|---|---|
| committer | Willy Tarreau <w@1wt.eu> | 2017-02-10 11:04:01 +0100 |
| commit | 0d9dddc0b582237e0e8afa19f83a3844fa9a846e (patch) | |
| tree | da7392d872b6afb1be3ffc921f29368e8f18e725 | |
| parent | 6d97f02a6c0faa8cef0bae45cc2f16fbaf38332a (diff) | |
| download | linux-stable-0d9dddc0b582237e0e8afa19f83a3844fa9a846e.tar.gz linux-stable-0d9dddc0b582237e0e8afa19f83a3844fa9a846e.tar.bz2 linux-stable-0d9dddc0b582237e0e8afa19f83a3844fa9a846e.zip | |
mmc: mxs: Initialize the spinlock prior to using it
commit f91346e8b5f46aaf12f1df26e87140584ffd1b3f upstream.
An interrupt may occur right after devm_request_irq() is called and
prior to the spinlock initialization, leading to a kernel oops,
as the interrupt handler uses the spinlock.
In order to prevent this problem, move the spinlock initialization
prior to requesting the interrupts.
Fixes: e4243f13d10e (mmc: mxs-mmc: add mmc host driver for i.MX23/28)
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Reviewed-by: Marek Vasut <marex@denx.de>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Willy Tarreau <w@1wt.eu>
| -rw-r--r-- | drivers/mmc/host/mxs-mmc.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c index 4278a1787d08..f3a423213108 100644 --- a/drivers/mmc/host/mxs-mmc.c +++ b/drivers/mmc/host/mxs-mmc.c @@ -674,13 +674,13 @@ static int mxs_mmc_probe(struct platform_device *pdev) platform_set_drvdata(pdev, mmc); + spin_lock_init(&host->lock); + ret = devm_request_irq(&pdev->dev, irq_err, mxs_mmc_irq_handler, 0, DRIVER_NAME, host); if (ret) goto out_free_dma; - spin_lock_init(&host->lock); - ret = mmc_add_host(mmc); if (ret) goto out_free_dma; |