diff options
| author | Willy Tarreau <w@1wt.eu> | 2017-05-16 19:18:55 +0200 |
|---|---|---|
| committer | Willy Tarreau <w@1wt.eu> | 2017-06-08 00:47:12 +0200 |
| commit | 66cb32401b6041356f0be44a302cdb42c20de6c2 (patch) | |
| tree | e93c19e83a786fb1669e233d602ab785e9346067 | |
| parent | 2f954a6249770ef5f2588aab0ca182238028628f (diff) | |
| download | linux-stable-66cb32401b6041356f0be44a302cdb42c20de6c2.tar.gz linux-stable-66cb32401b6041356f0be44a302cdb42c20de6c2.tar.bz2 linux-stable-66cb32401b6041356f0be44a302cdb42c20de6c2.zip | |
char: lp: fix possible integer overflow in lp_setup()
commit 3e21f4af170bebf47c187c1ff8bf155583c9f3b1 upstream.
The lp_setup() code doesn't apply any bounds checking when passing
"lp=none", and only in this case, resulting in an overflow of the
parport_nr[] array. All versions in Git history are affected.
Reported-By: Roee Hay <roee.hay@hcl.com>
Cc: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Willy Tarreau <w@1wt.eu>
| -rw-r--r-- | drivers/char/lp.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/char/lp.c b/drivers/char/lp.c index 0913d79424d3..6b619105dea8 100644 --- a/drivers/char/lp.c +++ b/drivers/char/lp.c @@ -857,7 +857,11 @@ static int __init lp_setup (char *str) } else if (!strcmp(str, "auto")) { parport_nr[0] = LP_PARPORT_AUTO; } else if (!strcmp(str, "none")) { - parport_nr[parport_ptr++] = LP_PARPORT_NONE; + if (parport_ptr < LP_NO) + parport_nr[parport_ptr++] = LP_PARPORT_NONE; + else + printk(KERN_INFO "lp: too many ports, %s ignored.\n", + str); } else if (!strcmp(str, "reset")) { reset = 1; } |