diff options
| author | Alexander Usyskin <alexander.usyskin@intel.com> | 2014-08-25 16:46:53 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-11-21 09:22:55 -0800 |
| commit | ba8beb4ca84e22996b0f553248ea52c760afb930 (patch) | |
| tree | 625e7874e0bca527f0b7d839e130d009e71b5cbd | |
| parent | 858879737bb5b7b7dca1d84df9018e7eb46d7294 (diff) | |
| download | linux-stable-ba8beb4ca84e22996b0f553248ea52c760afb930.tar.gz linux-stable-ba8beb4ca84e22996b0f553248ea52c760afb930.tar.bz2 linux-stable-ba8beb4ca84e22996b0f553248ea52c760afb930.zip | |
mei: bus: fix possible boundaries violation
commit cfda2794b5afe7ce64ee9605c64bef0e56a48125 upstream.
function 'strncpy' will fill whole buffer 'id.name' of fixed size (32)
with string value and will not leave place for NULL-terminator.
Possible buffer boundaries violation in following string operations.
Replace strncpy with strlcpy.
Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/misc/mei/bus.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/misc/mei/bus.c b/drivers/misc/mei/bus.c index 99cc0b07a713..0513ea0906dd 100644 --- a/drivers/misc/mei/bus.c +++ b/drivers/misc/mei/bus.c @@ -71,7 +71,7 @@ static int mei_cl_device_probe(struct device *dev) dev_dbg(dev, "Device probe\n"); - strncpy(id.name, dev_name(dev), MEI_CL_NAME_SIZE); + strlcpy(id.name, dev_name(dev), sizeof(id.name)); return driver->probe(device, &id); } |