diff options
| author | Eric Dumazet <edumazet@google.com> | 2014-04-03 09:28:10 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-05-31 13:20:39 -0700 |
| commit | fc2ab6e8f4903f3e2da6ea0a807403fc91f8debb (patch) | |
| tree | 7944b2dbc66cc2d130b07d75a9c291b673af6a1f | |
| parent | 242339a25ed829432d99e6571d170b308432ed55 (diff) | |
| download | linux-stable-fc2ab6e8f4903f3e2da6ea0a807403fc91f8debb.tar.gz linux-stable-fc2ab6e8f4903f3e2da6ea0a807403fc91f8debb.tar.bz2 linux-stable-fc2ab6e8f4903f3e2da6ea0a807403fc91f8debb.zip | |
net-gro: reset skb->truesize in napi_reuse_skb()
[ Upstream commit e33d0ba8047b049c9262fdb1fcafb93cb52ceceb ]
Recycling skb always had been very tough...
This time it appears GRO layer can accumulate skb->truesize
adjustments made by drivers when they attach a fragment to skb.
skb_gro_receive() can only subtract from skb->truesize the used part
of a fragment.
I spotted this problem seeing TcpExtPruneCalled and
TcpExtTCPRcvCollapsed that were unexpected with a recent kernel, where
TCP receive window should be sized properly to accept traffic coming
from a driver not overshooting skb->truesize.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | net/core/dev.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/core/dev.c b/net/core/dev.c index 62d29d94dbbf..fccc195e0fc8 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -4051,6 +4051,7 @@ static void napi_reuse_skb(struct napi_struct *napi, struct sk_buff *skb) skb->vlan_tci = 0; skb->dev = napi->dev; skb->skb_iif = 0; + skb->truesize = SKB_TRUESIZE(skb_end_offset(skb)); napi->skb = skb; } |