diff options
| author | Yangtao Li <tiny.windzz@gmail.com> | 2018-12-26 08:36:58 -0500 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2019-07-09 22:03:41 +0100 |
| commit | 5f02a65d16726bb32dc284337adf4f3170eef67c (patch) | |
| tree | 3cf7eb7721d25a52ce9e07789714f7a8f67e0d64 | |
| parent | 14e535d7fffd131971f8a6ee79f690951c57a312 (diff) | |
| download | linux-stable-5f02a65d16726bb32dc284337adf4f3170eef67c.tar.gz linux-stable-5f02a65d16726bb32dc284337adf4f3170eef67c.tar.bz2 linux-stable-5f02a65d16726bb32dc284337adf4f3170eef67c.zip | |
clk: armada-370: fix refcount leak in a370_clk_init()
commit a3c24050bdf70c958a8d98c2823b66ea761e6a31 upstream.
The of_find_compatible_node() returns a node pointer with refcount
incremented, but there is the lack of use of the of_node_put() when
done. Add the missing of_node_put() to release the refcount.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Reviewed-by: Gregory CLEMENT <gregory.clement@bootlin.com>
Fixes: 07ad6836fa21 ("clk: mvebu: armada-370: maintain clock init order")
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
| -rw-r--r-- | drivers/clk/mvebu/armada-370.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/clk/mvebu/armada-370.c b/drivers/clk/mvebu/armada-370.c index bef198a83863..f9679a4f973a 100644 --- a/drivers/clk/mvebu/armada-370.c +++ b/drivers/clk/mvebu/armada-370.c @@ -168,8 +168,10 @@ static void __init a370_clk_init(struct device_node *np) mvebu_coreclk_setup(np, &a370_coreclks); - if (cgnp) + if (cgnp) { mvebu_clk_gating_setup(cgnp, a370_gating_desc); + of_node_put(cgnp); + } } CLK_OF_DECLARE(a370_clk, "marvell,armada-370-core-clock", a370_clk_init); |