diff options
| author | Yangtao Li <tiny.windzz@gmail.com> | 2018-12-26 08:42:26 -0500 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2019-07-09 22:03:42 +0100 |
| commit | 75bb57f077ebfa37961fa02dc4d0cf54d3632a49 (patch) | |
| tree | 095fdb197ee6554876f4c33dcfb9cb94dcba1470 | |
| parent | 88566fe4e98b296a7b4a34322f147366dc0bbdd8 (diff) | |
| download | linux-stable-75bb57f077ebfa37961fa02dc4d0cf54d3632a49.tar.gz linux-stable-75bb57f077ebfa37961fa02dc4d0cf54d3632a49.tar.bz2 linux-stable-75bb57f077ebfa37961fa02dc4d0cf54d3632a49.zip | |
clk: armada-xp: fix refcount leak in axp_clk_init()
commit db20a90a4b6745dad62753f8bd2f66afdd5abc84 upstream.
The of_find_compatible_node() returns a node pointer with refcount
incremented, but there is the lack of use of the of_node_put() when
done. Add the missing of_node_put() to release the refcount.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Reviewed-by: Gregory CLEMENT <gregory.clement@bootlin.com>
Fixes: 0a11a6ae9437 ("clk: mvebu: armada-xp: maintain clock init order")
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
| -rw-r--r-- | drivers/clk/mvebu/armada-xp.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/clk/mvebu/armada-xp.c b/drivers/clk/mvebu/armada-xp.c index b3094315a3c0..2fa15a274719 100644 --- a/drivers/clk/mvebu/armada-xp.c +++ b/drivers/clk/mvebu/armada-xp.c @@ -202,7 +202,9 @@ static void __init axp_clk_init(struct device_node *np) mvebu_coreclk_setup(np, &axp_coreclks); - if (cgnp) + if (cgnp) { mvebu_clk_gating_setup(cgnp, axp_gating_desc); + of_node_put(cgnp); + } } CLK_OF_DECLARE(axp_clk, "marvell,armada-xp-core-clock", axp_clk_init); |