summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYangtao Li <tiny.windzz@gmail.com>2018-12-26 08:40:19 -0500
committerBen Hutchings <ben@decadent.org.uk>2019-07-09 22:03:41 +0100
commit88566fe4e98b296a7b4a34322f147366dc0bbdd8 (patch)
tree7547d0f3e50bd610101523911dadb4e531ebf347
parent5f02a65d16726bb32dc284337adf4f3170eef67c (diff)
downloadlinux-stable-88566fe4e98b296a7b4a34322f147366dc0bbdd8.tar.gz
linux-stable-88566fe4e98b296a7b4a34322f147366dc0bbdd8.tar.bz2
linux-stable-88566fe4e98b296a7b4a34322f147366dc0bbdd8.zip
clk: kirkwood: fix refcount leak in kirkwood_clk_init()
commit e7beeab9c61591cd0e690d8733d534c3f4278ff8 upstream. The of_find_compatible_node() returns a node pointer with refcount incremented, but there is the lack of use of the of_node_put() when done. Add the missing of_node_put() to release the refcount. Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> Reviewed-by: Gregory CLEMENT <gregory.clement@bootlin.com> Fixes: 58d516ae95cb ("clk: mvebu: kirkwood: maintain clock init order") Signed-off-by: Stephen Boyd <sboyd@kernel.org> [bwh: Backported to 3.16: adjust context] Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
-rw-r--r--drivers/clk/mvebu/kirkwood.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/clk/mvebu/kirkwood.c b/drivers/clk/mvebu/kirkwood.c
index ddb666a86500..8457b48f1395 100644
--- a/drivers/clk/mvebu/kirkwood.c
+++ b/drivers/clk/mvebu/kirkwood.c
@@ -236,8 +236,11 @@ static void __init kirkwood_clk_init(struct device_node *np)
else
mvebu_coreclk_setup(np, &kirkwood_coreclks);
- if (cgnp)
+ if (cgnp) {
mvebu_clk_gating_setup(cgnp, kirkwood_gating_desc);
+
+ of_node_put(cgnp);
+ }
}
CLK_OF_DECLARE(kirkwood_clk, "marvell,kirkwood-core-clock",
kirkwood_clk_init);